Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754673AbbKCBfz (ORCPT ); Mon, 2 Nov 2015 20:35:55 -0500 Received: from mail-pa0-f50.google.com ([209.85.220.50]:34908 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754637AbbKCBfs (ORCPT ); Mon, 2 Nov 2015 20:35:48 -0500 Date: Tue, 3 Nov 2015 10:35:35 +0900 From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Brendan Gregg , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Frederic Weisbecker , Andi Kleen , Kan Liang Subject: Re: [RFC/PATCH 0/4] perf report: Support folded callchain output (v2) Message-ID: <20151103013535.GD11498@danjae.kornet> References: <1446469069-16223-1-git-send-email-namhyung@kernel.org> <20151102213021.GA21609@kernel.org> <20151102221204.GB10949@danjae.kornet> <20151102222842.GB21609@kernel.org> <20151102224927.GA11498@danjae.kornet> <20151102230436.GD21609@kernel.org> <20151102234606.GB11498@danjae.kornet> <20151103004647.GE21609@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20151103004647.GE21609@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1290 Lines: 33 On Mon, Nov 02, 2015 at 09:46:47PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Nov 03, 2015 at 08:46:06AM +0900, Namhyung Kim escreveu: > > On Mon, Nov 02, 2015 at 08:04:36PM -0300, Arnaldo Carvalho de Melo wrote: > > > I still think that this is a 'perf report' thing, but one that is > > > centered in callchains, and that is to be consumed by scripts, not > > > humans. > > > Agreed. > > > I'm just looking for a way to support it with minimal change. :) > > Hey, me too. A --no-hists flag looks like a quickie, no need to isolate > callchain code, or anything like that, just one long option switch and > we get what we need. Hmm.. okay. Let me think about the --no-hists flags then. What do you want to do if the --no-hists flags is used without folded callchain mode or other than --stdio? And if you want to print other info in the callchains, what would be the output of non-folded mode? I think the simplest solution would be supporting the folded mode only and error out other cases. Is it ok to you? Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/