Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754842AbbKCECU (ORCPT ); Mon, 2 Nov 2015 23:02:20 -0500 Received: from mail-pa0-f48.google.com ([209.85.220.48]:33195 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751593AbbKCECS (ORCPT ); Mon, 2 Nov 2015 23:02:18 -0500 Date: Mon, 2 Nov 2015 20:02:16 -0800 From: Jeremiah Mahler To: Jarkko Nikula Cc: Wolfram Sang , Mika Westerberg , Dudley Du , linux-kernel@vger.kernel.org Subject: [BUG, bisect] i2c: designware: Move common probe code into i2c_dw_probe() Message-ID: <20151103040216.GA2843@newt.localdomain> Mail-Followup-To: Jeremiah Mahler , Jarkko Nikula , Wolfram Sang , Mika Westerberg , Dudley Du , linux-kernel@vger.kernel.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2039 Lines: 46 Jarkko, all, Commit d80d134182ba5 introduced a bug which causes a cyapa based touch pad on an Acer C720 Chromebook to become inoperative. This is present in the latest linux-next (20151101). The patch description is repeated below. From d80d134182ba536ececab8d5fca50d779befc9a6 Mon Sep 17 00:00:00 2001 From: Jarkko Nikula Date: Mon, 12 Oct 2015 16:55:35 +0300 Subject: [PATCH] i2c: designware: Move common probe code into i2c_dw_probe() There is some code duplication in i2c-designware-platdrv and i2c-designware-pcidrv probe functions. What is even worse that duplication requires i2c_dw_xfer(), i2c_dw_func() and i2c_dw_isr() i2c-designware-core functions to be exported. Therefore move common code into new i2c_dw_probe() and make functions above local to i2c-designware-core. While merging the code patch does following functional changes: - I2C Adapter name will be "Synopsys DesignWare I2C adapter". Previously it was used for platform and ACPI devices but PCI device used "i2c-designware-pci". - Using device name for interrupt name. Previous it was platform device name, ACPI device name or "i2c-designware-pci". - Error code from devm_request_irq() and i2c_add_numbered_adapter() will be printed in case of error. Signed-off-by: Jarkko Nikula Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-designware-core.c | 49 +++++++++++++++++++++++++---- drivers/i2c/busses/i2c-designware-core.h | 5 +-- drivers/i2c/busses/i2c-designware-pcidrv.c | 30 ++---------------- drivers/i2c/busses/i2c-designware-platdrv.c | 28 ++--------------- 4 files changed, 49 insertions(+), 63 deletions(-) -- - Jeremiah Mahler -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/