Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754662AbbKCER4 (ORCPT ); Mon, 2 Nov 2015 23:17:56 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:39378 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750716AbbKCERx (ORCPT ); Mon, 2 Nov 2015 23:17:53 -0500 Date: Mon, 02 Nov 2015 23:17:50 -0500 (EST) Message-Id: <20151102.231750.1882562463767220834.davem@davemloft.net> To: igal.liberman@freescale.com Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, scottwood@freescale.com, madalin.bucur@freescale.com, pebolle@tiscali.nl, joakim.tjernlund@transmode.se, ppc@mindchasers.com, stephen@networkplumber.org Subject: Re: [v7, 2/6] fsl/fman: Add FMan support From: David Miller In-Reply-To: <1446467416-15992-3-git-send-email-igal.liberman@freescale.com> References: <1446467416-15992-1-git-send-email-igal.liberman@freescale.com> <1446467416-15992-3-git-send-email-igal.liberman@freescale.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 02 Nov 2015 20:17:53 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 673 Lines: 21 From: Date: Mon, 2 Nov 2015 14:30:12 +0200 > +static int clear_iram(struct fman *fman) > +{ > + struct fman_iram_regs __iomem *iram; > + int i, count; > + > + iram = (struct fman_iram_regs __iomem *)(fman->base_addr + IMEM_OFFSET); "fman->base_addr" is of type "void __iomem *", therefore no cast should be necessary at all. Please audit your entire driver submission for this problem. THanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/