Subject: Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions
To: Vinod Koul <vinod.koul@intel.com>
References: <1446444460-21600-1-git-send-email-okaya@codeaurora.org>
 <1446444460-21600-3-git-send-email-okaya@codeaurora.org>
 <20151103041528.GS21326@localhost>
Cc: dmaengine@vger.kernel.org, timur@codeaurora.org, cov@codeaurora.org,
        jcm@redhat.com, Dan Williams <dan.j.williams@intel.com>,
        linux-kernel@vger.kernel.org
From: Sinan Kaya <okaya@codeaurora.org>
Message-ID: <5638359D.9080507@codeaurora.org>
Date: Mon, 2 Nov 2015 23:18:37 -0500
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <20151103041528.GS21326@localhost>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1361
Lines: 40


On 11/2/2015 11:15 PM, Vinod Koul wrote:
> On Mon, Nov 02, 2015 at 01:07:38AM -0500, Sinan Kaya wrote:
>> This patch adds supporting utility functions
>> for selftest. The intention is to share the self
>> test code between different drivers.
>>
>> Supported test cases include:
>> 1. dma_map_single
>> 2. streaming DMA
>> 3. coherent DMA
>> 4. scatter-gather DMA
>
> This seems quite similar to dmatest, any reason why you cannot use/enhance
> that?
>
Dmatest is a standalone kernel module intended for stress testing DMA 
engines from userspace with N number of threads and M size combinations etc.

This one; on the other hand, is selftest to verify hardware is working 
as expected during power up.

Almost all DMA engine drivers come with some sort of selftest code 
called from probe. I followed the same design pattern.

I think the goal is to remove the duplicate self test code in all 
drivers over time.


-- 
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a 
Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/