Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752515AbbKCFgN (ORCPT ); Tue, 3 Nov 2015 00:36:13 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:45611 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750957AbbKCFgM (ORCPT ); Tue, 3 Nov 2015 00:36:12 -0500 Date: Tue, 3 Nov 2015 05:35:55 +0000 From: Mark Brown To: John Stultz Cc: Bjorn Andersson , Sascha Hauer , Ulf Hansson , lkml Message-ID: <20151103053555.GM20228@sirena.org.uk> References: <20151102204620.GF24668@usrtlx11787.corpusers.net> <20151102225856.GL20228@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uwB7x3tnyrZQfZJI" Content-Disposition: inline In-Reply-To: X-Cookie: Even bytes get lonely for a little bit. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: MMC/regulator boot hang in -next X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1575 Lines: 44 --uwB7x3tnyrZQfZJI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 02, 2015 at 03:04:29PM -0800, John Stultz wrote: > On Mon, Nov 2, 2015 at 2:58 PM, Mark Brown wrote: > > No, the internal get voltage call shouldn't be locking in the first > > place (and indeed it doesn't do so AFAICT?). > } else if (rdev->supply) { > ret =3D regulator_get_voltage(rdev->supply); <----- > } else { > Where _regulator_get_voltage() is called from > regulator_set_voltage_unlocked(), called from regulator_set_voltage(). >=20 Well, that's the issue then - get_voltage() needs to be locking the supplies like set_voltage() does. --uwB7x3tnyrZQfZJI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWOEe6AAoJECTWi3JdVIfQtPoH/0Jadp+off6fQNG6QRHuFUg/ CwM2DBBmRVzABd+c9V2Sq4nYw8KgT8r29bDyH98sj9wtFrSclsykU2H0YhmkM7yJ oaY0cu/bhGanN9qq6xwpQeLkvovMF0So1N1VD2zhj/1i38UnCjTPgnYNeQKM6tkS 1TVpY1BzTs+GaWQniQG/DGCn0K6jBMyIegeIdQiA48HAS9kYm14ye+b6FXcqZhEo uHFF7HSGn8PLjm5FLoqwebBUDHiNgAJkTi/GC/X3mGovwfR1R2BjZm3SJ/sDdb4a 2wZNl6yJw4GuHkSGsx2l0BrkjVzL7ZFw3f79cUl5TSD0IXjuVGZkzQcrfwtN+yI= =8eRl -----END PGP SIGNATURE----- --uwB7x3tnyrZQfZJI-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/