Date: Tue, 3 Nov 2015 12:00:09 +0530
From: Vinod Koul <vinod.koul@intel.com>
To: Sinan Kaya <okaya@codeaurora.org>
Cc: dmaengine@vger.kernel.org, timur@codeaurora.org, cov@codeaurora.org,
        jcm@redhat.com, Dan Williams <dan.j.williams@intel.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions
Message-ID: <20151103063009.GT21326@localhost>
References: <1446444460-21600-1-git-send-email-okaya@codeaurora.org>
 <1446444460-21600-3-git-send-email-okaya@codeaurora.org>
 <20151103041528.GS21326@localhost>
 <5638359D.9080507@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5638359D.9080507@codeaurora.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1562
Lines: 48

On Mon, Nov 02, 2015 at 11:18:37PM -0500, Sinan Kaya wrote:
> 
> 
> On 11/2/2015 11:15 PM, Vinod Koul wrote:
> >On Mon, Nov 02, 2015 at 01:07:38AM -0500, Sinan Kaya wrote:
> >>This patch adds supporting utility functions
> >>for selftest. The intention is to share the self
> >>test code between different drivers.
> >>
> >>Supported test cases include:
> >>1. dma_map_single
> >>2. streaming DMA
> >>3. coherent DMA
> >>4. scatter-gather DMA
> >
> >This seems quite similar to dmatest, any reason why you cannot use/enhance
> >that?
> >
> Dmatest is a standalone kernel module intended for stress testing
> DMA engines from userspace with N number of threads and M size
> combinations etc.
> 
> This one; on the other hand, is selftest to verify hardware is
> working as expected during power up.
> 
> Almost all DMA engine drivers come with some sort of selftest code
> called from probe. I followed the same design pattern.

which ones ?

> 
> I think the goal is to remove the duplicate self test code in all
> drivers over time.

and what prevents us from having common selftest plus dmatest code. Most of
the code here to do selftest is _same_ dmaengine routine code used in
dmatest

We can have common code which is used for dmatest as well as selftest. I do
not want to see same code duplicated..

-- 
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/