Subject: Re: [PATCH RESEND 14/16] hwmon: add TI LMU hardware fault monitoring
 driver
To: Guenter Roeck <linux@roeck-us.net>
References: <1446441875-1256-1-git-send-email-milo.kim@ti.com>
 <1446441875-1256-15-git-send-email-milo.kim@ti.com>
 <563772D7.4030807@roeck-us.net>
CC: <devicetree@vger.kernel.org>, <lee.jones@linaro.org>,
        <linux-kernel@vger.kernel.org>, Jean Delvare <jdelvare@suse.com>,
        <lm-sensors@lm-sensors.org>
From: "Kim, Milo" <milo.kim@ti.com>
Message-ID: <56385BCE.5060300@ti.com>
Date: Tue, 3 Nov 2015 16:01:34 +0900
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <563772D7.4030807@roeck-us.net>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1147
Lines: 29

Hi Guenter,

On 11/2/2015 11:27 PM, Guenter Roeck wrote:
> On 11/01/2015 09:24 PM, Milo Kim wrote:
>> LM3633 and LM3697 are TI LMU MFD device.
>> Those device have hardware monitoring feature which detects opened or
>> shorted circuit case.
>>
> Sure, but it only makes sense if you provide standard hwmon attributes
> which can be interpreted by the "sensors" command. Which is not the case
> here. You neither have a standard device type (light is not handled by hwmon),
> nor standard attributes, nor do the attributes return standard values.
>
> I think there may be a basic misunderstanding. hwmon is not intended
> to monitor a specific chip on the board. Its scope is to monitor the
> system (such as temperature, voltages, or current).
>
> In your case, it might be better to attach the attributes to the mfd device.
>

OK, got your point. Thanks a lot for your suggestion.

Best regards,
Milo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/