Date: Tue, 3 Nov 2015 15:03:38 +0800
From: Peter Chen <peter.chen@freescale.com>
To: Valentin Rothberg <valentinrothberg@gmail.com>
CC: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Andreas Ziegler" <ziegler@cs.fau.de>
Subject: Re: Documentation: update of USB_CHIPIDEA_DEBUG
Message-ID: <20151103070337.GB21081@shlinux2>
References: <20151102091508.GB100007@vm-valentin>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20151102091508.GB100007@vm-valentin>
User-Agent: Mutt/1.5.21 (2010-09-15)
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2015 07:05:31.6376
 (UTC)
X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB0731
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1618
Lines: 39

On Mon, Nov 02, 2015 at 05:15:08PM +0800, Valentin Rothberg wrote:
> Hi Peter,
> 
> your commit 2fb2884ed856 ("usb: chipidea: delete static debug support")
> has shown up in today's Linux next tree (i.e., next-20151102) and
> removes the Kconfig option USB_CHIPIDEA_DEBUG in favor of dynamic debug
> support.  However, there are some documentary references on this option
> still left in the code that may need to be updated:
> 
> Documentation/usb/chipidea.txt-9-If you want to check some internal variables for otg fsm,
> Documentation/usb/chipidea.txt:10:select CONFIG_USB_CHIPIDEA_DEBUG, there are 2 files which
>                                          ^^^^^^^^^^^^^^^^^^^^^^^^^
> Documentation/usb/chipidea.txt-11-can show otg fsm variables and some controller registers value:
> --
> drivers/usb/chipidea/core.c-25- * Compile Options
> drivers/usb/chipidea/core.c:26: * - CONFIG_USB_CHIPIDEA_DEBUG: enable debug facilities
>                                     ^^^^^^^^^^^^^^^^^^^^^^^^^
> drivers/usb/chipidea/core.c-27- * - STALL_IN:  non-empty bulk-in pipes cannot be halted
> 
> 
> I'm just pointing to those references, since I don't know if you want to
> keep them in the code or not.  I found the issue and your commit with
> scipts/checkkconfigsymbols.py.

Thanks, Valentin. I will change them.

> 
> Kind regards,
>  Valentin

-- 

Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/