Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753036AbbKCIGA (ORCPT ); Tue, 3 Nov 2015 03:06:00 -0500 Received: from smtp.transmode.se ([31.15.61.139]:52038 "EHLO smtp.transmode.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751855AbbKCIF6 convert rfc822-to-8bit (ORCPT ); Tue, 3 Nov 2015 03:05:58 -0500 X-Greylist: delayed 597 seconds by postgrey-1.27 at vger.kernel.org; Tue, 03 Nov 2015 03:05:57 EST From: Joakim Tjernlund To: "netdev@vger.kernel.org" , "madalin.bucur@freescale.com" CC: "scottwood@freescale.com" , "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "ppc@mindchasers.com" , "roy.pledge@freescale.com" , "igal.liberman@freescale.com" , "pebolle@tiscali.nl" , "joe@perches.com" , "gregkh@linuxfoundation.org" , "davem@davemloft.net" Subject: Re: [net-next v4 2/8] dpaa_eth: add support for DPAA Ethernet Thread-Topic: [net-next v4 2/8] dpaa_eth: add support for DPAA Ethernet Thread-Index: AQHRFg0SU6lBpzJ6+UO7a+jGMrQHpw== Date: Tue, 3 Nov 2015 07:55:57 +0000 Message-ID: <1446537357.21216.49.camel@transmode.se> References: <1446485500-9782-1-git-send-email-madalin.bucur@freescale.com> <1446485500-9782-3-git-send-email-madalin.bucur@freescale.com> In-Reply-To: <1446485500-9782-3-git-send-email-madalin.bucur@freescale.com> Accept-Language: en-US, sv-SE Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.16.5 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [192.168.200.4] Content-Type: text/plain; charset=US-ASCII Content-ID: Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 960 Lines: 20 On Mon, 2015-11-02 at 19:31 +0200, Madalin Bucur wrote: > + if (unlikely(fd_status & FM_FD_STAT_RX_ERRORS) != 0) { > + if (net_ratelimit()) > + netif_warn(priv, hw, net_dev, "FD status = 0x%08x\n", > + fd_status & FM_FD_STAT_RX_ERRORS); > + > + percpu_stats->rx_errors++; > + goto _release_frame; > + } I cannot find any detailed error accounting(maybe I am not looking hard enough) but I would appreciate if both TX and RX errors where better accounted(rx_length_errors, rx_frame_errors, rx_crc_errors, rx_fifo_errors etc.). This has helped me many times in the past diagnosing board HW problems. Jocke-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/