Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754450AbbKCIZu (ORCPT ); Tue, 3 Nov 2015 03:25:50 -0500 Received: from mail-vk0-f50.google.com ([209.85.213.50]:36665 "EHLO mail-vk0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751020AbbKCIZt (ORCPT ); Tue, 3 Nov 2015 03:25:49 -0500 MIME-Version: 1.0 In-Reply-To: <1446106653-15896-1-git-send-email-drinkcat@chromium.org> References: <1446106653-15896-1-git-send-email-drinkcat@chromium.org> Date: Tue, 3 Nov 2015 16:25:48 +0800 Message-ID: Subject: Re: [PATCH] mfd: cros ec: Lock the SPI bus while holding chipselect From: Nicolas Boichat To: Lee Jones Cc: linux-kernel@vger.kernel.org, Javier Martinez Canillas , Olof Johansson , Douglas Anderson , Randall Spangler , Gwendal Grignou Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 645 Lines: 20 +gwendal@chromium.org On Thu, Oct 29, 2015 at 4:17 PM, Nicolas Boichat wrote: > @@ -482,6 +493,7 @@ static int cros_ec_pkt_xfer_spi(struct cros_ec_device *ec_dev, > > ret = len; > exit: > + spi_bus_unlock(ec_spi->spi->master); Gwendal noted offline that I could unlock the bus earlier, just after terminate_request. I'll do that and send a v2 soon. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/