From: Madalin-Cristian Bucur <madalin.bucur@freescale.com>
To: Joakim Tjernlund <joakim.tjernlund@transmode.se>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC: Scott Wood <scottwood@freescale.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "ppc@mindchasers.com" <ppc@mindchasers.com>,
        Roy Pledge <roy.pledge@freescale.com>,
        Liberman Igal <Igal.Liberman@freescale.com>,
        "pebolle@tiscali.nl" <pebolle@tiscali.nl>,
        "joe@perches.com" <joe@perches.com>,
        "davem@davemloft.net" <davem@davemloft.net>
Subject: RE: [net-next v4 2/8] dpaa_eth: add support for DPAA Ethernet
Thread-Topic: [net-next v4 2/8] dpaa_eth: add support for DPAA Ethernet
Thread-Index: AQHRFYxH+cy2rV2E7kS8BKip6D6VU56J7wyAgAAXsUA=
Date: Tue, 3 Nov 2015 09:37:22 +0000
Message-ID: <BL2PR03MB545ED95392F5CB88EC06B11E62B0@BL2PR03MB545.namprd03.prod.outlook.com>
References: <1446485500-9782-1-git-send-email-madalin.bucur@freescale.com>
	 <1446485500-9782-3-git-send-email-madalin.bucur@freescale.com>
 <1446537357.21216.49.camel@transmode.se>
In-Reply-To: <1446537357.21216.49.camel@transmode.se>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2015 09:37:22.6463
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR03MB500
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1441
Lines: 38

> -----Original Message-----
> From: Joakim Tjernlund [mailto:joakim.tjernlund@transmode.se]
> 
> On Mon, 2015-11-02 at 19:31 +0200, Madalin Bucur wrote:
> > +       if (unlikely(fd_status & FM_FD_STAT_RX_ERRORS) != 0) {
> > +               if (net_ratelimit())
> > +                       netif_warn(priv, hw, net_dev, "FD status =
> 0x%08x\n",
> > +                                  fd_status & FM_FD_STAT_RX_ERRORS);
> > +
> > +               percpu_stats->rx_errors++;
> > +               goto _release_frame;
> > +       }
> 
> I cannot find any detailed error accounting(maybe I am not looking hard
> enough) but I
> would appreciate if both TX and RX errors where better
> accounted(rx_length_errors, rx_frame_errors,
> rx_crc_errors, rx_fifo_errors etc.). This has helped me many times in the
> past diagnosing
> board HW problems.
> 
>  Jocke

Hi Jocke,

There are some error counters exported through ethtool (used to be debugfs).
FMan HW provides more debug information than we currently export, that will be
improved in the future but given the current priority of having a codebase as
small and reviewable as possible we had to drop some things from the initial
submission.

Madalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/