Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753473AbbKCLBI (ORCPT ); Tue, 3 Nov 2015 06:01:08 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:2491 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753218AbbKCLBE (ORCPT ); Tue, 3 Nov 2015 06:01:04 -0500 From: Wang Nan To: CC: , , , Wang Nan , Arnaldo Carvalho de Melo Subject: [PATCH 3/5] perf tools: Parsing libbpf return value using err.h Date: Tue, 3 Nov 2015 10:44:44 +0000 Message-ID: <1446547486-229499-4-git-send-email-wangnan0@huawei.com> X-Mailer: git-send-email 1.8.3.4 In-Reply-To: <1446547486-229499-1-git-send-email-wangnan0@huawei.com> References: <1446547486-229499-1-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.107.193.248] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090203.563893E6.00FF,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: d4217ee18e25e4c9804dd5f7154a352e Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1969 Lines: 61 In following patches libbpf would encode error code using return pointer instead of returnning a NULL pointer to indicate error. This patch makes a preperation to enable perf correctly receive error code from libbpf. Signed-off-by: Wang Nan Cc: Arnaldo Carvalho de Melo --- tools/perf/tests/llvm.c | 2 +- tools/perf/util/bpf-loader.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/perf/tests/llvm.c b/tools/perf/tests/llvm.c index 512d362..38e0d9a 100644 --- a/tools/perf/tests/llvm.c +++ b/tools/perf/tests/llvm.c @@ -27,7 +27,7 @@ static int test__bpf_parsing(void *obj_buf, size_t obj_buf_sz) struct bpf_object *obj; obj = bpf_object__open_buffer(obj_buf, obj_buf_sz, NULL); - if (!obj) + if (IS_ERR(obj) || !obj) return -1; bpf_object__close(obj); return 0; diff --git a/tools/perf/util/bpf-loader.c b/tools/perf/util/bpf-loader.c index 0c5d174..dd6fa27 100644 --- a/tools/perf/util/bpf-loader.c +++ b/tools/perf/util/bpf-loader.c @@ -59,9 +59,9 @@ struct bpf_object *bpf__prepare_load(const char *filename, bool source) } else obj = bpf_object__open(filename); - if (!obj) { + if (IS_ERR(obj) || !obj) { pr_debug("bpf: failed to load %s\n", filename); - return ERR_PTR(-EINVAL); + return !obj ? ERR_PTR(-EINVAL) : obj; } return obj; @@ -96,9 +96,9 @@ config_bpf_program(struct bpf_program *prog) int err; config_str = bpf_program__title(prog, false); - if (!config_str) { + if (IS_ERR(config_str) || !config_str) { pr_debug("bpf: unable to get title for program\n"); - return -EINVAL; + return !config_str ? -EINVAL : PTR_ERR(config_str); } priv = calloc(sizeof(*priv), 1); -- 1.8.3.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/