Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754156AbbKCN1Q (ORCPT ); Tue, 3 Nov 2015 08:27:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60794 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752663AbbKCN1P (ORCPT ); Tue, 3 Nov 2015 08:27:15 -0500 From: Jeff Moyer To: Ming Lei Cc: Jens Axboe , Jason Luo , Linux Kernel Mailing List , Guru Anbalagane , Feng Jin , Tejun Heo Subject: Re: [patch, v2] blk-mq: avoid excessive boot delays with large lun counts References: X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Tue, 03 Nov 2015 08:27:13 -0500 In-Reply-To: (Ming Lei's message of "Tue, 3 Nov 2015 09:12:16 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 963 Lines: 28 Ming Lei writes: >>> The above should be 'else if', otherwise the current queue will be set >>> twice. >> >> I moved the list add below this to avoid that very issue. See: >> >>>> + queue_set_hctx_shared(q, true); >>>> list_add_tail(&q->tag_set_list, &set->tag_list); >> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >> >> This seemed the cleanest way to structure the code to avoid the double >> walking of the hctx list for the current q. > > OK, it is correct, then v1 is fine. > > Reviewed-by: Ming Lei Thanks, Ming. Jens, I'll re-send with the list_is_singular change and this one should be ready for merging. Cheers, Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/