Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754106AbbKCNpt (ORCPT ); Tue, 3 Nov 2015 08:45:49 -0500 Received: from mail-lf0-f42.google.com ([209.85.215.42]:35395 "EHLO mail-lf0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751312AbbKCNps (ORCPT ); Tue, 3 Nov 2015 08:45:48 -0500 Subject: Re: [PATCH 05/23] usb: gadget: configfs: fix error path To: Robert Baldyga , balbi@ti.com References: <1446555242-3733-1-git-send-email-r.baldyga@samsung.com> <1446555242-3733-6-git-send-email-r.baldyga@samsung.com> Cc: gregkh@linuxfoundation.org, andrzej.p@samsung.com, m.szyprowski@samsung.com, b.zolnierkie@samsung.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Message-ID: <5638BA87.3080402@cogentembedded.com> Date: Tue, 3 Nov 2015 16:45:43 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1446555242-3733-6-git-send-email-r.baldyga@samsung.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 648 Lines: 25 Hello. On 11/3/2015 3:53 PM, Robert Baldyga wrote: > As usb_gstrings_attach() fail can happen when some USB functions are Failure? > are already added to some configurations (in prevoius loop iterations), Previous? > we should always call purge_configs_funcs() to be sure that failure is > be handled properly. > > Signed-off-by: Robert Baldyga [...] MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/