Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753866AbbKCPGI (ORCPT ); Tue, 3 Nov 2015 10:06:08 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:52502 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750817AbbKCPGE (ORCPT ); Tue, 3 Nov 2015 10:06:04 -0500 From: Felipe Balbi To: Nathan Sullivan CC: , , Subject: Re: [PATCH V4] usb: remove unnecessary CONFIG_PM dependency from USB_OTG In-Reply-To: <20151103145328.GA17283@nathan3500-linux-VM> References: <1446126743-31892-1-git-send-email-nathan.sullivan@ni.com> <8737wnnq3c.fsf@saruman.tx.rr.com> <20151103145328.GA17283@nathan3500-linux-VM> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Tue, 3 Nov 2015 09:05:58 -0600 Message-ID: <87wptzm8bt.fsf@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2577 Lines: 78 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Nathan Sullivan writes: > On Tue, Nov 03, 2015 at 07:56:55AM -0600, Felipe Balbi wrote: >>=20 >> Hi, >>=20 >> Nathan Sullivan writes: >> > The USB OTG support currently depends on power management >> > (CONFIG_PM) being enabled, but does not actually need it enabled. >> > Remove this dependency. >> > >> > Tested on Bay Trail hardware with dwc3 USB. >> > >> > Signed-off-by: Nathan Sullivan >> > --- >> > drivers/usb/core/Kconfig | 1 - >> > 1 file changed, 1 deletion(-) >> > >> > diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig >> > index a99c89e..9c5cdf3 100644 >> > --- a/drivers/usb/core/Kconfig >> > +++ b/drivers/usb/core/Kconfig >> > @@ -43,7 +43,6 @@ config USB_DYNAMIC_MINORS >> >=20=20 >> > config USB_OTG >> > bool "OTG support" >> > - depends on PM >>=20 >> I don't think this is correct. OTG depends on USB bus suspend, which is >> only available on PM builds. Care to further detail why you think PM is >> not needed on OTG ? >>=20 >> --=20 >> balbi > > I think we can drop this patch, actually. > > It looks like we confused gadget and OTG support at some point in the > past, and we don't want PM on our hardware for latency reasons. We > really only need USB gadget support, not full OTG. Fair enough, thank you =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWOM1WAAoJEIaOsuA1yqREabwQAIAzXYidg5WtMPX6v/GI0CQq 45ENMC97qj5GrixG8p3hfcbCawp1wvN9rOFVrCzS9FuyQIbj1LSO5EWbpYrm349d GozRzqdLtit4niQ44kUJ5ijFVmFKCUH/7bPTVRB864mSxMAGLiPzMcxMGGaacNr3 tItuczGBkJd/uAm+DDZPKWpXg7+lQRE8YgwEht4Wn4zadFV+pyNA5Qq/5j4r4dY2 ZYwGVXArvmW2IFrPRdOqDdMYVnpLa+RzMzOG6LRY48u7un2Mwbf08OcCsEaG9blO TsTKJfPZvnQCBQtTDKmAcVOxIt3rqx0mCOVGjj+O9Gzp7TcYn+l9cIu+gMGKTgF5 ddVY9bRfjeJmXDbZYteTa4DmnydOh10WUMePGHaHY7bwtJPZh/tJQt7piTjYsb6w wbSatU1ZcXM0uQVHyV6shs5JxNiaE7IkQO0psojik7kpJLjk9qnSMLXkb/caEhrH yEwxYDphdKFp4rmn2YzWBg1ggzXyzlOtgHwlViQR+nTdKDY3sCajQjANoDjrauby XnDd6EpxLvvo47EDYtj5WMo1wjRLfSvSxzvXnC3q/kBbUgd+p0f7rr7OkKTudgk2 PEsZbWUCWGykKse2OC2EO1UdztzsEP8YqY+4gUy0wi/JpbefOY35tnny+4+mjzfy Ov7WVo2MpHW4HDzWSbsm =Po3p -----END PGP SIGNATURE----- --=-=-=-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/