Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755446AbbKCQJJ (ORCPT ); Tue, 3 Nov 2015 11:09:09 -0500 Received: from mail-db3on0093.outbound.protection.outlook.com ([157.55.234.93]:44694 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752995AbbKCPST convert rfc822-to-8bit (ORCPT ); Tue, 3 Nov 2015 10:18:19 -0500 From: Noam Camus To: Vineet Gupta , "linux-snps-arc@lists.infradead.org" CC: "linux-kernel@vger.kernel.org" , Tal Zilcer , Gil Fruchter , Chris Metcalf , Daniel Lezcano , "Rob Herring" , Thomas Gleixner , "John Stultz" Subject: RE: [PATCH v1 02/20] clocksource: Add NPS400 timers driver Thread-Topic: [PATCH v1 02/20] clocksource: Add NPS400 timers driver Thread-Index: AQHRE951aFhaJcfF3ku8/lfO2RvsuZ6IlJMAgAHYklA= Date: Tue, 3 Nov 2015 15:18:15 +0000 Message-ID: References: <1446297327-16298-1-git-send-email-noamc@ezchip.com> <1446297327-16298-3-git-send-email-noamc@ezchip.com> <56374318.4030109@synopsys.com> In-Reply-To: <56374318.4030109@synopsys.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=noamc@ezchip.com; x-originating-ip: [212.179.42.66] x-microsoft-exchange-diagnostics: 1;DB5PR02MB1144;5:A9rkFyR836dfH7MCmmyTVZnuvYeCYIN5n35y8sNrqmKcjH6TxhYQ2mipUgM8avASAXF+i2QZ3FXZ/dAthcv0fm8f9a1BZYLUt7BQ7Qui3twzJesgtcYA/JGoD3wLsJNkLc3Lc1D2kZY8kBUnTNCzhg==;24:9PN5qmsIQRW5fGF5eeAGX+NuVLcfvex7hAJuTw4mhkwrDPyL+GMRc+SZwT13NNG0fyJaFPSxNYxby+9EvltWxtC9aBbdgrBwEyeXaU5+lTI=;20:JKH4tpuhAipT39XCKa1/xLrYKO2aMj2srjSsIrkiP0lU65gcdr7+y0wsIltT0GSWpz075368e3QR9227KY3jVg== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR02MB1144; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(10201501046)(3002001);SRVR:DB5PR02MB1144;BCL:0;PCL:0;RULEID:;SRVR:DB5PR02MB1144; x-forefront-prvs: 0749DC2CE6 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(189002)(199003)(377454003)(66066001)(19580395003)(5001960100002)(2900100001)(97736004)(74316001)(81156007)(11100500001)(102836002)(101416001)(5001920100001)(5001770100001)(10400500002)(33656002)(105586002)(2950100001)(40100003)(189998001)(106356001)(76576001)(122556002)(5002640100001)(5007970100001)(77096005)(50986999)(92566002)(106116001)(5008740100001)(87936001)(5004730100002)(76176999)(5003600100002)(54356999)(2501003)(19580405001)(86362001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB5PR02MB1144;H:DB5PR02MB1141.eurprd02.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2015 15:18:16.0866 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0fc16e0a-3cd3-4092-8b2f-0a42cff122c3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR02MB1144 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 697 Lines: 26 From: Vineet Gupta [mailto:Vineet.Gupta1@synopsys.com] Sent: Monday, November 02, 2015 1:04 PM >> + >> + upper = ioread32be(upper_p); >Consider using the _relaxed macros even if your platform doesn't have specific IO barriers. [Noam Camus] What is the big endian flavor for _relaxed macros. >> + counter = upper; >> + counter <<= 32; >> + counter |= lower; >It is easier to read: >counter = (upper << 32) | lower; Thanks I will update - Noam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/