Date: Tue, 3 Nov 2015 12:20:36 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Wang Nan <wangnan0@huawei.com>
Cc: lizefan@huawei.com, pi3orama@163.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] perf tools: Parsing libbpf return value using err.h
Message-ID: <20151103152036.GP21609@kernel.org>
References: <1446547486-229499-1-git-send-email-wangnan0@huawei.com>
 <1446547486-229499-4-git-send-email-wangnan0@huawei.com>
 <20151103151716.GO21609@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151103151716.GO21609@kernel.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1170
Lines: 33

Em Tue, Nov 03, 2015 at 12:17:16PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Nov 03, 2015 at 10:44:44AM +0000, Wang Nan escreveu:
> > +++ b/tools/perf/tests/llvm.c
> > @@ -27,7 +27,7 @@ static int test__bpf_parsing(void *obj_buf, size_t obj_buf_sz)
> >  	struct bpf_object *obj;

> >  	obj = bpf_object__open_buffer(obj_buf, obj_buf_sz, NULL);
> > -	if (!obj)
> > +	if (IS_ERR(obj) || !obj)
 
> Well, since we've adopted IS_ERR() from the kernel, we better try to
> follow how it is used there, no?
 
> Since you move to use ERR_PTR(), you probably will never return NULL,
> right? So whay the (|| !obj) part?
 
> The kernel has an IS_ERR_OR_NULL() interface tho, trying to figure out
> when that would be appropriate...

I think you should change the error reporting convention _and_ the users
at the same time, i.e. please merge this patch with the next and use
plain:

	if (IS_ERR(obj))

Instead, ok?

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/