Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932716AbbKCPYg (ORCPT ); Tue, 3 Nov 2015 10:24:36 -0500 Received: from mail-ob0-f180.google.com ([209.85.214.180]:33091 "EHLO mail-ob0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932606AbbKCPYA (ORCPT ); Tue, 3 Nov 2015 10:24:00 -0500 Subject: Re: [patch, v2] blk-mq: avoid excessive boot delays with large lun counts To: Jeff Moyer , Ming Lei References: Cc: Jason Luo , Linux Kernel Mailing List , Guru Anbalagane , Feng Jin , Tejun Heo From: Jens Axboe Message-ID: <5638D18D.6010805@kernel.dk> Date: Tue, 3 Nov 2015 08:23:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1054 Lines: 32 On 11/03/2015 06:27 AM, Jeff Moyer wrote: > Ming Lei writes: > >>>> The above should be 'else if', otherwise the current queue will be set >>>> twice. >>> >>> I moved the list add below this to avoid that very issue. See: >>> >>>>> + queue_set_hctx_shared(q, true); >>>>> list_add_tail(&q->tag_set_list, &set->tag_list); >>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >>> >>> This seemed the cleanest way to structure the code to avoid the double >>> walking of the hctx list for the current q. >> >> OK, it is correct, then v1 is fine. >> >> Reviewed-by: Ming Lei > > Thanks, Ming. Jens, I'll re-send with the list_is_singular change and > this one should be ready for merging. Great, thanks Jeff! -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/