Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755413AbbKCQPS (ORCPT <rfc822;w@1wt.eu>);
	Tue, 3 Nov 2015 11:15:18 -0500
Received: from mailout3.w1.samsung.com ([210.118.77.13]:46662 "EHLO
	mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755059AbbKCQPK (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 3 Nov 2015 11:15:10 -0500
X-AuditID: cbfec7f5-f794b6d000001495-01-5638dd8b3369
Message-id: <5638DD8A.5020105@samsung.com>
Date: Tue, 03 Nov 2015 17:15:06 +0100
From: Jacek Anaszewski <j.anaszewski@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804
 Thunderbird/17.0.8
MIME-version: 1.0
To: Milo Kim <milo.kim@ti.com>
Cc: devicetree@vger.kernel.org, lee.jones@linaro.org,
        linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH RESEND 04/16] Documentation: dt-bindings: leds: add LM3633
 LED binding information
References: <1446441875-1256-1-git-send-email-milo.kim@ti.com>
 <1446441875-1256-5-git-send-email-milo.kim@ti.com>
In-reply-to: <1446441875-1256-5-git-send-email-milo.kim@ti.com>
Content-type: text/plain; charset=ISO-8859-1; format=flowed
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrBLMWRmVeSWpSXmKPExsVy+t/xa7rddy3CDH5d4rWYf+Qcq8X9r0cZ
	LS7vmsNmsfXNOkaL5b/WsTiwety5tofN4/iN7UwenzfJBTBHcdmkpOZklqUW6dslcGVcvdLK
	WvBVoKJh6XymBsY5vF2MnBwSAiYSu65cZoawxSQu3FvP1sXIxSEksJRRYl7DIiYI5xmjxPfL
	18CqeAW0JG40bGEDsVkEVCVWrb3ODmKzCRhK/HzxmgnEFhWIkPhzeh8rRL2gxI/J91hAbBEB
	OYlls/aA9TILFEjM2bOMEcQWFsiQWLv+L9gcIYFiiUuN28HinAL2EpOnz2WGqLeWWDlpGyOE
	LS+xec1b5gmMArOQrJiFpGwWkrIFjMyrGEVTS5MLipPSc430ihNzi0vz0vWS83M3MULC9+sO
	xqXHrA4xCnAwKvHwLlhiHibEmlhWXJl7iFGCg1lJhFf1nEWYEG9KYmVValF+fFFpTmrxIUZp
	DhYlcd6Zu96HCAmkJ5akZqemFqQWwWSZODilGhiXb77IodESn/L52P9Mbd99h72V+3O/LXXw
	L/on7MYrfPBuhk5rUvKldo0rk4zvcbgZlTmteru4v+1MU2XndD6LyRurDnS0nFbik3X9ULZT
	4YZ0jsJd/ujnhis/f2bbyHSgnklg/nOVwl9HZAVrt93/8ezV1qvr277M/8zofeVIVVle6CIR
	x61KLMUZiYZazEXFiQDqDpIOWwIAAA==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2349
Lines: 66

Hi Milo,

Thanks for the patch. Apart from the issues
pointed out by Rob, I have one more suggestion below.

On 11/02/2015 06:24 AM, Milo Kim wrote:
> LM3633 LED device is one of TI LMU device list.
>
> Cc: devicetree@vger.kernel.org
> Cc: Jacek Anaszewski <j.anaszewski@samsung.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-leds@vger.kernel.org
> Signed-off-by: Milo Kim <milo.kim@ti.com>
> ---
>   .../devicetree/bindings/leds/leds-lm3633.txt       | 28 ++++++++++++++++++++++
>   1 file changed, 28 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3633.txt
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3633.txt b/Documentation/devicetree/bindings/leds/leds-lm3633.txt
> new file mode 100644
> index 0000000..bb7f213
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-lm3633.txt
> @@ -0,0 +1,28 @@
> +TI LMU LM3633 LED device tree bindings
> +
> +Required properties:
> +  - compatible: "ti,lm3633-leds"
> +
> +Child nodes:
> +  Each node matches with LED control bank.
> +  Please refer to the datasheet [1].
> +
> +  Required properties of a child node:
> +  - lvled1-used, lvled2-used, lvled3-used,
> +    lvled4-used, lvled5-used, lvled6-used:
> +    Low voltage LED string configuration. Type is <boolean>.
> +    Please describe which output LED string is used.
> +
> +  Optional properties of a child node:
> +  - channel-name: Name string for LED channel identification
> +                  It is used for creating LED sysfs,
> +                  /sys/class/leds/<channel-name>/.
> +                  If this property is empty, then default name is set to
> +                  "indicator:<id>" by the driver.
> +  - led-max-microamp: Max current setting. Type is <u32>.
> +                      Unit is microampere. Range is from 5000 to 30000.

Could you specify also a step?

> +Examples: Please refer to ti-lmu dt-bindings [2].
> +
> +[1] http://www.ti.com/product/LM3633/datasheet
> +[2] Documentation/devicetree/bindings/mfd/ti-lmu.txt
>


-- 
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/