Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755597AbbKCQfZ (ORCPT ); Tue, 3 Nov 2015 11:35:25 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:45269 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755507AbbKCQfX (ORCPT ); Tue, 3 Nov 2015 11:35:23 -0500 Date: Tue, 03 Nov 2015 11:35:18 -0500 (EST) Message-Id: <20151103.113518.611629631978527699.davem@davemloft.net> To: vivien.didelot@savoirfairelinux.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, f.fainelli@gmail.com, andrew@lunn.ch Subject: Re: [PATCH net] net: dsa: mv88e6xxx: include DSA ports in VLANs From: David Miller In-Reply-To: <1446565972-4269-1-git-send-email-vivien.didelot@savoirfairelinux.com> References: <1446565972-4269-1-git-send-email-vivien.didelot@savoirfairelinux.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 03 Nov 2015 08:35:22 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 895 Lines: 22 From: Vivien Didelot Date: Tue, 3 Nov 2015 10:52:52 -0500 > DSA ports must be members of a VLAN in order to ensure frame bridging > between chained switch chips. > > Thus tag them in addition to the CPU port when adding a VLAN, and skip > them when deleting a VLAN and reporting VLAN members. > > Also use the UNMODIFIED egress policy, so that frames egress on these > ports as they ingress, tagged or untagged. > > Fixes: 0d3b33e60206 ("net: dsa: mv88e6xxx: add VLAN Load support") > Reported-by: Andrew Lunn > Signed-off-by: Vivien Didelot Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/