Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755147AbbKCR3V (ORCPT ); Tue, 3 Nov 2015 12:29:21 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:46242 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751415AbbKCR3S (ORCPT ); Tue, 3 Nov 2015 12:29:18 -0500 Date: Tue, 3 Nov 2015 17:29:11 +0000 From: Mark Brown To: Saurabh Sengar Cc: linux-kernel@vger.kernel.org, lgirdwood@gmail.com Message-ID: <20151103172910.GR20228@sirena.org.uk> References: <20151101022911.GD28319@sirena.org.uk> <1446457680-21318-1-git-send-email-saurabh.truth@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GDLQamdgIxhPcIwq" Content-Disposition: inline In-Reply-To: <1446457680-21318-1-git-send-email-saurabh.truth@gmail.com> X-Cookie: Even bytes get lonely for a little bit. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v2] regulator: of: removing two variables min_uV and max_uV X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1574 Lines: 43 --GDLQamdgIxhPcIwq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 02, 2015 at 03:18:00PM +0530, Saurabh Sengar wrote: > replacing the of_get_property function with of_property_read_u32 function > as its help removing two variables. > I have put these check back, please let me know if this v2 patch is worth It's a bit marginal TBH and... > /* Only one voltage? Then make sure it's set. */ > - if (min_uV && max_uV && constraints->min_uV == constraints->max_uV) > + if (constraints->min_uV && constraints->max_uV > + && constraints->min_uV == constraints->max_uV) > constraints->apply_uV = true; ...this does disallow a constraint of 0-XuV which was previously legal and potentially meaningful. Hrm. --GDLQamdgIxhPcIwq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWOO7mAAoJECTWi3JdVIfQhvQH/ilFqpEdcp3w+9z19xFEIFOe vQ0DpddfEvJRcNJRnW99yMyLCBHF5EDkWoEPiMi9FaaZsKTUxWLeAebUQyiXynM/ 8Zh6EjBOrFpTqrOLnULHKBQV08HC0x47dktAUSChvgKe0yAIfKi96VQy9rUZ9UDP OM7yvc4UeYQeHy6KdFW9RQ062qsoe6pVT523LGoxGzJ8NYEOi0ayK3NYvn93xm1f 24a9+kqvGDzBGaKUf8ITusF5d+Q/6bR20Xt/lPOviIDqTvSJSMOo1ZLywTj8IRza 2t24hyNJ0we9l5QaoCFDlYpyksPyHVPYC/tbtn3VhOP1ncMGzCujjKtrTamce+8= =+7K3 -----END PGP SIGNATURE----- --GDLQamdgIxhPcIwq-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/