Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755572AbbKCRgB (ORCPT ); Tue, 3 Nov 2015 12:36:01 -0500 Received: from mail-ob0-f181.google.com ([209.85.214.181]:34307 "EHLO mail-ob0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755038AbbKCRf6 (ORCPT ); Tue, 3 Nov 2015 12:35:58 -0500 MIME-Version: 1.0 In-Reply-To: <5638ECEC.1030604@oracle.com> References: <1415969446-26356-1-git-send-email-a.ryabinin@samsung.com> <5638ECEC.1030604@oracle.com> From: Dmitry Vyukov Date: Tue, 3 Nov 2015 18:35:38 +0100 Message-ID: Subject: Re: [PATCH v2 0/2] UBSan: run-time undefined behavior sanity checker To: Sasha Levin Cc: Andrey Ryabinin , LKML , Andrew Morton , Peter Zijlstra , Randy Dunlap , Rasmus Villemoes , Jonathan Corbet , Michal Marek , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Yury Gribov , Konstantin Khlebnikov , "x86@kernel.org" , linux-doc@vger.kernel.org, "open list:KERNEL BUILD + fi..." Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2816 Lines: 60 I guess just nobody reviewed this. I would like to see this merged as well. On Tue, Nov 3, 2015 at 6:20 PM, Sasha Levin wrote: > Anyone knows why wasn't this merged a year ago? I didn't see any review comments, and it > ended up finding real bugs. > > On 11/14/2014 07:50 AM, Andrey Ryabinin wrote: >> Next spin of UBSan and there are two patches from now. >> "Two there should be; no more, no less. One to embody the UBSan, >> the other to not deadlock it." >> >> Patches on top of v3.18-rc4. As usual they are available in git: >> git://github.com/aryabinin/linux ubsan/v2 >> >> Changes since v1: >> - Refactoring and cleanups in lib/ubsan.c including Sasha's complains. >> - Some spelling fixes from Randy >> - Fixed possible memory corruption on 64 big endian machines, spotted by Rasmus. >> - Links to the relevant GCC documentation added into changelog (Peter). >> - Added documentation. >> - Fix deadlock caused by kernel/printk/printk.c instrumentation >> (patch "kernel: printk: specify alignment for struct printk_log"). >> - Dropped useless 'Indirect call of a function through a function pointer of the wrong type' >> checker. GCC doesn't support this, and as clang manual says it's for C++ only. >> - Added checker for __builtin_unreachable() calls. >> - Removed redundant -fno-sanitize=float-cast-overflow from CFLAGS. >> - Added lock to prevent mixing reports. >> >> Andrey Ryabinin (2): >> kernel: printk: specify alignment for struct printk_log >> UBSan: run-time undefined behavior sanity checker >> >> Documentation/ubsan.txt | 69 +++++ >> Makefile | 10 +- >> arch/x86/Kconfig | 1 + >> arch/x86/boot/Makefile | 1 + >> arch/x86/boot/compressed/Makefile | 1 + >> arch/x86/realmode/rm/Makefile | 1 + >> arch/x86/vdso/Makefile | 2 + >> drivers/firmware/efi/libstub/Makefile | 1 + >> include/linux/sched.h | 3 + >> kernel/printk/printk.c | 10 +- >> lib/Kconfig.debug | 22 ++ >> lib/Makefile | 3 + >> lib/ubsan.c | 567 ++++++++++++++++++++++++++++++++++ >> lib/ubsan.h | 84 +++++ >> scripts/Makefile.lib | 6 + >> 15 files changed, 775 insertions(+), 6 deletions(-) >> create mode 100644 Documentation/ubsan.txt >> create mode 100644 lib/ubsan.c >> create mode 100644 lib/ubsan.h >> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/