Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755582AbbKCRix (ORCPT ); Tue, 3 Nov 2015 12:38:53 -0500 Received: from mail-pa0-f49.google.com ([209.85.220.49]:33180 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752466AbbKCRiw (ORCPT ); Tue, 3 Nov 2015 12:38:52 -0500 From: Saurabh Sengar To: matt@codeblueprint.co.uk, linux-kernel@vger.kernel.org Subject: Re: [PATCH] efi: replace GFP_KERNEL with GFP_ATOMIC Date: Tue, 3 Nov 2015 23:08:46 +0530 Message-Id: <1446572326-5831-1-git-send-email-saurabh.truth@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <20151103163650.GE2653@codeblueprint.co.uk> References: <20151103163650.GE2653@codeblueprint.co.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 688 Lines: 15 >It's slightly winding code, but if you look at the callers of >efivar_init() you'll see that none of them set both 'atomic' and >'duplicates', so dup_variable_bug() will never be called while holding >a spinlock. >Or am I missing something? I was assuming that there could be a possibility when both 'atomic' and 'duplicates' are set. If both can never be set, then this patch does not make any sense, you are correct. Thank you for review -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/