Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755932AbbKCSPX (ORCPT ); Tue, 3 Nov 2015 13:15:23 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:33015 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755862AbbKCSPU (ORCPT ); Tue, 3 Nov 2015 13:15:20 -0500 Date: Tue, 3 Nov 2015 10:15:18 -0800 From: Jeremiah Mahler To: Jarkko Nikula Cc: Wolfram Sang , Mika Westerberg , Dudley Du , linux-kernel@vger.kernel.org Subject: Re: [BUG, bisect] i2c: designware: Move common probe code into i2c_dw_probe() Message-ID: <20151103181518.GA3110@newt.localdomain> Mail-Followup-To: Jeremiah Mahler , Jarkko Nikula , Wolfram Sang , Mika Westerberg , Dudley Du , linux-kernel@vger.kernel.org References: <20151103040216.GA2843@newt.localdomain> <56386237.9080904@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56386237.9080904@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1859 Lines: 57 Jarkko, On Tue, Nov 03, 2015 at 09:28:55AM +0200, Jarkko Nikula wrote: > Hi > > On 03.11.2015 06:02, Jeremiah Mahler wrote: > >Jarkko, all, > > > >Commit d80d134182ba5 introduced a bug which causes a cyapa based touch > >pad on an Acer C720 Chromebook to become inoperative. This is present > >in the latest linux-next (20151101). The patch description is repeated > >below. > > [...] > Oh, I didn't notice adapter name was used > drivers/platform/chrome/chromeos_laptop.c. Could you try does a patch below > help? > > ============================ CUT HERE ============================ > diff --git a/drivers/platform/chrome/chromeos_laptop.c > b/drivers/platform/chrome/chromeos_laptop.c > index 02072749fff3..2b441e9ae593 100644 > --- a/drivers/platform/chrome/chromeos_laptop.c > +++ b/drivers/platform/chrome/chromeos_laptop.c > @@ -47,8 +47,8 @@ static const char *i2c_adapter_names[] = { > "SMBus I801 adapter", > "i915 gmbus vga", > "i915 gmbus panel", > - "i2c-designware-pci", > - "i2c-designware-pci", > + "Synopsys DesignWare I2C adapter", > + "Synopsys DesignWare I2C adapter", > }; > > /* Keep this enum consistent with i2c_adapter_names */ > ============================ CUT HERE ============================ > > -- > Jarkko > -- Yes, that change fixes the problem. Thanks for the quick fix. Tested-by: Jeremiah Mahler So the find_i2c_adapter_num function was looking for "i2c-designware-pci" but it should have been looking for "Synopsys DesignWare I2C adapter". Where does this bus name come from, is it read from the device itself? -- - Jeremiah Mahler -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/