Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755994AbbKCTdO (ORCPT ); Tue, 3 Nov 2015 14:33:14 -0500 Received: from mail-ig0-f172.google.com ([209.85.213.172]:36272 "EHLO mail-ig0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755707AbbKCTdM (ORCPT ); Tue, 3 Nov 2015 14:33:12 -0500 MIME-Version: 1.0 In-Reply-To: <14835877.IL6ArpWV8Q@wuerfel> References: <14835877.IL6ArpWV8Q@wuerfel> Date: Tue, 3 Nov 2015 11:33:11 -0800 Message-ID: Subject: Re: [PATCH] HID: hid-gfrm: avoid warning for input_configured API change From: Petri Gynther To: Arnd Bergmann Cc: Jiri Kosina , linux-input , Dmitry Torokhov , linux-kernel , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1809 Lines: 44 On Tue, Nov 3, 2015 at 6:56 AM, Arnd Bergmann wrote: > The input_configured callback was recently changed to return > an 'int', but the newly added driver uses the old API: > > drivers/hid/hid-gfrm.c:151:22: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types] > > This changes the driver like the other ones. > > Signed-off-by: Arnd Bergmann Acked-by: Petri Gynther > Fixes: 34fc1322e7aa ("HID: hid-gfrm: Google Fiber TV Box remote controls") > Fixes: b2c68a2f1bab ("HID: hid-input: allow input_configured callback return errors") > --- > Found on ARM allmodconfig with yesterday's linux-next > > diff --git a/drivers/hid/hid-gfrm.c b/drivers/hid/hid-gfrm.c > index 4d7b7e7f0792..075b1c020846 100644 > --- a/drivers/hid/hid-gfrm.c > +++ b/drivers/hid/hid-gfrm.c > @@ -88,7 +88,7 @@ static int gfrm_raw_event(struct hid_device *hdev, struct hid_report *report, > return (ret < 0) ? ret : -1; > } > > -static void gfrm_input_configured(struct hid_device *hid, struct hid_input *hidinput) > +static int gfrm_input_configured(struct hid_device *hid, struct hid_input *hidinput) > { > /* > * Enable software autorepeat with: > @@ -96,6 +96,7 @@ static void gfrm_input_configured(struct hid_device *hid, struct hid_input *hidi > * - repeat period: 100 msec > */ > input_enable_softrepeat(hidinput->input, 400, 100); > + return 0; > } > > static int gfrm_probe(struct hid_device *hdev, const struct hid_device_id *id) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/