Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932477AbbKCT7D (ORCPT ); Tue, 3 Nov 2015 14:59:03 -0500 Received: from mail-by2on0076.outbound.protection.outlook.com ([207.46.100.76]:34016 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932236AbbKCT7A (ORCPT ); Tue, 3 Nov 2015 14:59:00 -0500 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; 01.org; dkim=none (message not signed) header.d=none;01.org; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0NX98U7-07-DAN-02 X-M-MSG: Subject: Re: [PATCH] x86/intel_cacheinfo: Fix LLC topology for AMD Fam17h systems To: Borislav Petkov References: <201511040312.OQPDNtTX%fengguang.wu@intel.com> <56390E01.6050104@amd.com> <20151103195246.GB3644@pd.tnic> CC: kbuild test robot , , , , , , , , , , , From: Aravind Gopalakrishnan Message-ID: <563911FB.9070405@amd.com> Date: Tue, 3 Nov 2015 13:58:51 -0600 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151103195246.GB3644@pd.tnic> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(479174004)(189002)(199003)(377454003)(164054003)(24454002)(5007970100001)(5890100001)(2950100001)(92566002)(77096005)(5004730100002)(105586002)(189998001)(106466001)(99136001)(110136002)(83506001)(54356999)(97736004)(64126003)(65806001)(59896002)(87936001)(65956001)(33656002)(86362001)(76176999)(50466002)(50986999)(36756003)(23676002)(65816999)(4001350100001)(5008740100001)(230700001)(80316001)(11100500001)(47776003)(87266999)(101416001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR12MB0853;H:atltwp01.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0853;2:yyNKBgILnRtfnfZR8RTPx2BxTC89AcCBhCuN311KnDj5Laupg97cykYzV7SvVDDtNQwHZUHTClOiZi+MKl4Yo57Ac3X1HP2aMHGBflLJGEOIlTd1VS19m4doBZJ0uVX9Hrs2bc4VNB91tI4/gVVYzO7c7iIkoo6VWVF3pmB+qS0=;3:+ZdbPBzdMCveHPJ9rstrPcmVE5KR7Zax6MwvrvN/uvJBMht4fEPG56Tsfhg9915IBx1NtI6T2xRM8nhZ1weetNY5JoKaMTgVsTExkFxUaUHB0nso5LFlwoC0lMQm7dKjf6nFFgx4q6LksbJf70KORD++VV/lOQTi5pzmKmryMckNOWkC9JnmRpXN4LyL/7gBe55mKgpu86IC7o8NWdDCe8Qq8sNePD8/qHxtoZJWIo8DJMNKCLv5pEbK/JTm5opx;25:5q+RqzA/lJt3YeHmFPBbIZAAs8lVidBcZ37gQ9nTpzuQVjwqHGR/Sp2C/pgIK+cVpj26w69SivN6ChTlHOqfOv5Acu/8AsjcaHwZN/PrdjbtwT6GmDsusA3YSGwCIHCP9Oh6bHWfDs4FX1E7RyWz/2kETzC+GP7mGrYZ2nFjGDlhsnEhApZKdfE5iXhpMfs2VzmtXkG6MmgxsRBuZcskzyjxW3HzHO38JVv5ZDO0kiQpzylWnSJob+5ueBlilO/x2RieT7P9kkF8YV31as8ygA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0853; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0853;20:+MxchIVEMLgTl8SA34cUAkkYwP4Us/DlUbfCNVd2EHONzNOylEG2zLHbvtDV2o+Cr2o0KKGAFkLy8jvCaIcULsctREyGMcDE5Gjp8lvGjIz5LiFwuxxFAm8gHlTTMk57ZaJTU34TxJHjqM8mk3xOtwnYs0FBuNvbXmv42EQYGtNfUTNUenN2/jsyLFHxAGSqaF1NDZZjlrs2tuhSVXuTlTprGXOLJZdHKgaWr9T5OYUslb/fSHzDV1JJVbo2RFE5VH5vYFFDZdbO8VidXWFd0H2g/U1n6Tru1jgbU+VYxzEu7Cc1fTYwpm301TZhw7tacBt4S/HX2c6k5j0CCmXR3zRBPmlSz8F1W9VRxzmUzAkZnRkgHsoLOXw4mIpbwLQ2lddp+MalEPUr9vaiOP0gDdYYHY9o4fHsDovyqwzNgCgBlZUB8CR2fqrwPswSq8RuA3nk35T1VKMkzZlNfT62uMoJrgLgDfXJCYtCz62tDFoOVV3A3bRoryBqWGDFZYUV;4:3dexoA3Hvk7Rq3SMe++Kc4kt52yGHxf93P5fqUcYvOcb05JiWvC8evG2oQhFzpzAjIsch2ryCoUpoHogAieTMx5UUdTzVxVixPyWYTMzqZvuNxUqlxQObTGaOcQHkUR71KU7Hb63c/ZhpzTzVIH2KcXAnHbh5VWRuMBJbkJVU51cXqHmMye7WBQdAtt3ZtfDCFGJ0Y5CFpPPLGbYQprQ9l6mdtCRVWnq5d6XhuA+Gg+SuhUZjo7UVvlCPO3riLgefk8vsjeUQijQYIXeq2edEOX5eVBf6rrntRszjQTorZH6i2YVc7g7Zo/2P3AqruxCKvvJgSAcMAkRVMdgknxfb/SUacv35iEkizS/2KQ8jn/+CXuw8HqZ/+eIu6UHIhV8 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(10201501046)(3002001);SRVR:CY1PR12MB0853;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0853; X-Forefront-PRVS: 0749DC2CE6 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjEyTUIwODUzOzIzOm41YnV3WmQ0ZW9mTVllNGMwTWhhamUrSGN2?= =?utf-8?B?MTVzR0RCYXI4ZFZPMk1XSmd1VzlqUWd6Q291VjF0Rng1VU9GdW1uSHZ1NlBX?= =?utf-8?B?WWdtUmxEZ3pzUThBaVpkTlBpT0dLYVNlY0pDV1BWbU82bkdLU0FreUdJT295?= =?utf-8?B?ZE9IR2wrdUVTUW51aThUOEdhZitZd0lZL1N3MXk1VkxqQVVrdXJaaFRmczdF?= =?utf-8?B?WEtrM25oT2pwWjZaVDRObURzcHZZOVdudXpvc3lHQnZ5MDM3R3BtZGthbGZD?= =?utf-8?B?RWVqN29wd1NhNWN3ZVorLytiRExudnFrMk14TEpVRHpta3BtbVBodUMyS3Yr?= =?utf-8?B?MEc5S2ZJdHJpeHFKUkV1WGZyamJ2YUFaY2RZSXNFOHVrdS96Kzd1QnhHVVhy?= =?utf-8?B?eWw5SXlhc2g4cUY2dHZQWWpsTjdUQmRTenpzejZSeTB5ckk2VEhMeTlMR0Yv?= =?utf-8?B?MEFIbWtYeVdYS0hJcGlRQnQ0WUdFTVorWFBuTG1IU3BnT1lsNXRmQm5HMmg2?= =?utf-8?B?bFpyNmZMWnJpaHVzU2pvNy9xTkJuVzdZYnZQaVdQbnNHc000R01tUnU1NG1M?= =?utf-8?B?VC9XUDZyTDUyeTVBRUhRdE12enhHZ3NKdHh3cHlNZzVpTERONHNNRitkbGVq?= =?utf-8?B?YnF3QytGMnUzQ3VxUjJra0h5djRLRGNHbzhpYStkaFFqWU1DdksxM2ZQOHFj?= =?utf-8?B?eVpSWHZyR1JVY05reGpjY0lIMTlrRFRNNE1kUWlOVjNBZmZSRHNJZUNSNnZw?= =?utf-8?B?eWdFU2FQeGIrOE1ydUNrKzNBeWxwaFZCUmg0TXZaWXI5NXNYVWEyZVlvc0J4?= =?utf-8?B?U3ZHSTlucFJPT3RsWTA0OG03SjhOVVFYVHNRVXhFSWUzcnZBRkY3UEtBRFZU?= =?utf-8?B?Y1JZVmpCZ1ZvdUsrUmxHenZBa0k4clFIbXZrQndBMExPZ2dHeHRTVm5IL3Vn?= =?utf-8?B?Y011NEZmaW9zN2JVcUhCaGVIditFNG9EN21rejNuTDltUkkwdlNsMS9Id2FV?= =?utf-8?B?WndVaXlxNWdwQ1k1RS85RlQyS2JmMUdRdlJ6OVJ5WVN1Rk9OT09HNWdxOVo5?= =?utf-8?B?RnZrcW5kKzdPVzg3SVc0TXErbjBsWDdKVGQ1VWtnQlVqTU1ha2EzTnFGcFNV?= =?utf-8?B?MmoxM2J6a3JqaWdQR3crbVQrTFpwalFsT1ZoYS90TVAyVXV0WEZSeHRpY1pk?= =?utf-8?B?R3VhVTlmOExpVUxEb0M5UXViSFhhK29rUXpBd2F5dm5tNk54NjdSNFl0WHJE?= =?utf-8?B?U0o3SEZVVVJLdWtYYmszcmdwTUg2MlI3U1ZFYWd1NDJIU21leFBROG9HZW5s?= =?utf-8?B?S3FsaEZ1cXduU1ZEQ2VFMmlGSGEwckdPTDA1MDMrZXBkUHcyNm43ZHpIcGNC?= =?utf-8?B?UjNvQ1hDUUZmb09ZSHFxdGdZM2E0T0l1WGtjbXNSWUwzWkM0WHl3QnpVTkM3?= =?utf-8?B?Ry9SNHFZV0xZeWZoNTVrSmJyY3M0T2hPRjcrSkd0NkhDcVRUVys0eVBtbk5B?= =?utf-8?B?SUg0K2t0Qi9nZHpEdGhnSklZbDNpMFVWTEo3c3pIeXBzL01jZUdXY0ltamRM?= =?utf-8?B?U2N6Y2NWSXdYVmhFTmFXQkRNSm5ialE9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0853;5:xdcuPmD+RBz9Wij/BifyqGa5MOzbxxomzwN3Vbu4YyrH0textA/ldiJwtCrtO1Z8UAWHP3RBuEQEgn3CSk3QOfSol0x3GOHiSPKPbsZWiijq+2syzpd7dZWjxQy0LhXYV0VozZe2+6a0X0ZYm3d+EA==;24:xEcjmOosoYrOh6xv/pL7GG8FZD2qHnbb8O/n5qNWD03HQ16D6s04c8IafmGH8DkBo4pkd5oBY8z6+QpqqAh7wTJURSxNqR2DH1Qpb5eqPw0=;20:qvt9mn8RtI1kpRTlZlvgwF1EJwPxAUazwqv6a1F3mSWGkd9pHmy4e6DhmMRajKVscKBCIq4OFdN1jsfRy0tS5vZ9i394rZgTDSNOtrshKuKsegmUfwGGvh8wl2Gfqyqz3Jm+YehaCSxZIX8961Q5dwRYxtr92wHCrOyI/W/uugJMlwCHK18bKqXAZvQHnvUEJ2G+ISDVe5fcOvNxIwy7leLG++tJe1B/Ddqivwu5q08vW8p40rvSnVb+6wdYTRVZ SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2015 19:58:56.8166 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0853 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 925 Lines: 26 On 11/3/2015 1:52 PM, Borislav Petkov wrote: > On Tue, Nov 03, 2015 at 01:41:53PM -0600, Aravind Gopalakrishnan wrote: >> cpu_llc_id references should be wrapped under #ifdef CONFIG_SMP. >> >> Did that and kernel build worked with the attached config. >> >> Will send a V2 with the fix. > Why aren't you doing all that figuring out what the llc_id is in > amd_detect_cmp() which is already CONFIG_SMP ifdeffed? > > Which is where that code belongs anyway... > Since we needed to modify last level cache IDs, I thought init_amd_cacheinfo() might be a logical place to put it. But you are right, makes sense to move it to amd_detect_cmp(). I'll do that in V2. Thanks, -Aravind. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/