Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965211AbbKDAXH (ORCPT ); Tue, 3 Nov 2015 19:23:07 -0500 Received: from mail-bl2on0086.outbound.protection.outlook.com ([65.55.169.86]:28266 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932699AbbKDAVL (ORCPT ); Tue, 3 Nov 2015 19:21:11 -0500 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; linuxfoundation.org; dkim=none (message not signed) header.d=none;linuxfoundation.org; dmarc=bestguesspass action=none header.from=xilinx.com; From: Soren Brinkmann To: Greg Kroah-Hartman , Jiri Slaby CC: Michal Simek , , , , "Soren Brinkmann" Subject: [PATCH 6/9] tty: xuartps: Keep lock for whole ISR Date: Tue, 3 Nov 2015 16:20:47 -0800 Message-ID: <1446596450-20918-7-git-send-email-soren.brinkmann@xilinx.com> X-Mailer: git-send-email 2.6.2.3.ga463a5b In-Reply-To: <1446596450-20918-1-git-send-email-soren.brinkmann@xilinx.com> References: <1446596450-20918-1-git-send-email-soren.brinkmann@xilinx.com> X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21918.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD037;1:+Q1B5326BUHeTzt93kCaJyTpHZQR81LXWcrk5Um63RQJyBvtGm0meydSPM/PLNO2PZuhAtJdn2tE50bxSV8N3nhQzDaPnNEaBIdi8u7hKvvxTFh00QRzWR7sBuReTM6IqsU1Qh1Nwzv8KL0glMg3xCQunUFR7Z0f+WK8/HEpnpMTnVCBKbZVWkr6XWgFzURqff4WWhIU+NIuZoE4V4E3ZYMGVQqyNcKPIYPJeiCnedf2f1eynt5fVXoPXI7TOoIYee3byzFn1w8lj22aWnBBXDjedJlihqiMPitkWo914A/gchkJnYm0uNczxwBdp83n6yTUQRuFhwEQIz5Qin+P1FGy4I1BPfVAr0gP9FsZjBc= X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(189002)(199003)(19580405001)(77096005)(2950100001)(50226001)(4001430100002)(16796002)(5001960100002)(107886002)(92566002)(50986999)(76176999)(36386004)(87936001)(47776003)(48376002)(5001770100001)(81156007)(36756003)(33646002)(189998001)(50466002)(86362001)(229853001)(106466001)(6806005)(11100500001)(5001920100001)(5003940100001)(5008740100001)(19580395003)(57986006)(63266004)(76506005)(5007970100001)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1BFFO11HUB019;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;PTR:unknown-60-83.xilinx.com;MX:1;A:1;LANG:en; MIME-Version: 1.0 Content-Type: text/plain X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11HUB019;2:E2vr5QxRDbr5yz0Piwd6aUMqiHRpVpnRqAfVIZ+3YZKykh7xXp/gr0MmsFz1zdKhDgLWK2WH9Af1dKM/ruQ2oG6jAIFHPwEiqgnWaWn78Wp5zrJncopPJxbaaflzbfTDmAUhD2pHNJd5QBlZagTcCx49eisx6pZEG7/RLS1jAH0=;3:oyqSAiP9HLjnTVb76zOkdmqMpdSYNbOv2Lw7ZyE4dGX8/4a2dCONPkNXDJTC8FBEHJowiT94FUo8XPO+RxaDERuVp0oqbNCVvLeBTOf+UbofATUWVL9+zKjMWPYnfQCrsliqE4YiL4M3bRdXmdAFKSX0Y0AAgzoVj3S4Hw1TkX5K1l0+bfe/dN5fYxKgWDNzJyzAcAinABc05bmNmuRBlRnNqKhAOHkK0cZt/jlNsCI5EaQK+XVfhKslHFjm0QWSpBqIKHSl+bQE1oTrau63Aw==;25:tGJz9MYVCcSTt6OvJGpDzzib0lG593hhOs58RE8IzlfdcWZAnVgB+PkzJid6TITYtL/vH6+CyfybFTx74LDnZN56wHI/534czKSxWRB+TtKXkTSLVs2kvJlYu47yVKkHFH9lFmySbpUgpinjh2j7mT9dCeer2WUVXSSXUGNXGOwVbra1ZCdy1iZ6ieCrX5Sw43JM7PrMrhblyxnK4uKbU59NvRatYS0y0hLzbi5vbHdwR/pa6U/R4X/0XTz4KQ8kqem44/DzaXkUXsYSWKepug== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:BN1BFFO11HUB019; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11HUB019;20:xHrP4bSyFXtHVRUIgIPgUVKl+rf/4B+OED7KfCpliTRRQ160zTV477QL9pdWCbAoAvDolsocusKNGuLHvCwAw7XPPrsjtMl9k/MdyntqK6gM5jdm3szrzhpHV6DqZYs/rUx1S3fF7Azqx+jpYdvjmX+lCXPX8le3/mfpXL5dgfG8u+5aLcZuEhaAecwwbPSiHnFLQDvtEF7aizLqjjKVIi6XI9s6yr7mXC20hxs9QpgEIglwLF1H1J+2DfZxtKrCWlwaUt3N1xd8N21HBLZdwJrP0T8sQbZKdFKpSAppsAhBkyXW2jVMy0RIlfJf9RtRFZ7IHBKiU0UmR2iaPDKFa9We4zi8iT6bjWbil6WXkbdiv9gXtivWL4CJT1xQ8LMQiKZbMRpJzqWFfT2OjBzPn+qFQq2FBeb8uHzaoMgWPSOptVvNXHCyGm1nTrDgocJaREyR+mSiHueV7/rIwTIACuOnf0D8nlVZYMmeAikN492xornv3SJCg/ASWTKG+1Mv;4:4eP+5HmDLRM+jADDCN59irU/gt2kyNb0nzoNAlMtWOVDLpDhFkmM8q1FxKBazUgWP9QUJnxj4iiMYnTtcm1uQrqDhUn5XzqOMpQ6qgi8JH2sMMtei1IMFCbH6mSdNx5kndvQW7/TMG3dVGPNxnKamNPuOQscVayH8Dc0RD2EMrb8xgjo7ZDUms0H/u4vFKjNZ+Do38pO52EJbaBOeHV5HxCSeMWw8UVjErorwIKAB6nvwKYWv1djCe0m2/GuNie8idsKqUwLchtqsG13rScbTtArll7YXYXmD/un6hK+BKAvVtjfvWvEVz9fPew+XoiggbBKUh4uDGmla4zZLjUZc5Y8amfSy4K0s9aXNMQ1YeComgkBXlcgXk0slXhGNb6y X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(8121501046)(5005006)(10201501046)(3002001);SRVR:BN1BFFO11HUB019;BCL:0;PCL:0;RULEID:;SRVR:BN1BFFO11HUB019; X-Forefront-PRVS: 0750463DC9 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN1BFFO11HUB019;23:cv61BdTHFc+HnWx0PjkaGeZyLjDvlhdPYW4Euik?= =?us-ascii?Q?OVTGyL9tfvFNWcjpKrA/tUZM/3LC4OoEfF9GYKkF3FgulU7ZlZxuUBM69A8P?= =?us-ascii?Q?1VrrUlQyTEw53VknGTzu4DL9Zuo1p5FbMv6C8gLTCgkABD2HxiBtqpYc9pXS?= =?us-ascii?Q?fjrI7ZglSEiQ9VQhx1ziCp9MgbpLkacDk4BL4h6h1O7LnTjfzhmFDOf4svmQ?= =?us-ascii?Q?vtqMnq9zdcWQC0XEkMXif5vYey5PLot9B13Q0OUOTDd/7hCuEf9e2JI3H3U9?= =?us-ascii?Q?XeA8MYcxp6Q2MzclGpYhgDnWQd8qCHngoLemNRkj+1+1E1+Xn7jAjRU/ZYWz?= =?us-ascii?Q?oxDUEcFbOkPRVD62PbO+S8R3iQVseAfrcSzpKXEnADEgRZC+6VtwW3IE61KV?= =?us-ascii?Q?Icmzl+8yBOP2UbCgnZG0A/YoIH33dEjpliukG/F97i3DL9lUmZ97k7TYaEIc?= =?us-ascii?Q?r98IZMY0Ru1XKTj+4a9qC8GthmED02cjTwsVNQ6pr1v2lBfGyOqCcGAoiRPm?= =?us-ascii?Q?GzAQoJOFs5BT6/w9FwzsBbq8iA2dGCcY9b2Mrvw/u0mZ8ooLbJZ0GNiUTrPI?= =?us-ascii?Q?a8L3zn36b5tg5IpwZ/5CYwHVg5ED/CPFNXGSHdH7Gq8sXqSIKNqWLbHmgkXa?= =?us-ascii?Q?Qo9OHA5h8+SGjKFfhBeiZ2eJiJkcfX/3B76Z7nFsaw/QjgZek+OSQ59bSmIc?= =?us-ascii?Q?9zb9HFeBUBkXP9BunqMyELfGB/wH5HcpA6Uyho7LMbTMxOn/k8s44M61wK92?= =?us-ascii?Q?Peyx+pLVXt6pj0h7TBC4wNWfv67refgNZ3ZGiD9ZjNcMOq6c661rzQZ94dXR?= =?us-ascii?Q?0ZiHwnZ12/rh+Ham7e5bU5arJEUiXjhgj5r2H6OJZ7pP+uY91W5+KoYbQ7CP?= =?us-ascii?Q?hTNTsj8hFic3vvRhp8HB+cTc3cN5QpcV+nUiQyyPzMinoM/zetC+QMTSYb8H?= =?us-ascii?Q?oh0YnUbo8cyUFGjkqp7LgvqVe0AnRQtnzFtOV5izZ7HUxroX+9uYml+2AyF8?= =?us-ascii?Q?9dC0RNTzpc3lwsl2/DkE1YmP+iSaLyt8AKKjc//DPqLf48W9ItJeXcJJsWSN?= =?us-ascii?Q?OOojOf1jywS9BBem7FN5J18HG2dliFEhWAB3ecFr56OmIrcYSGsiMrG9x6EP?= =?us-ascii?Q?XvvrSMSWuc+o=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11HUB019;5:xOoafUOR9xc3Ex7+1/YcSJXnsqQOFK9xEWK0s8V7HyENhKUcA5fCNagxVjiZOmDJktL9hAmiqAJp4F1ITETf+bbYugnPm24qWuNck0tVV0pq0eQKy5hDL54+90F/Q4xk9Qtq2BCHBqEp/E8mPc4mYQ==;24:H5rN8kD/SpW1TPn2ejJnwFz4c26hGrfwnqbbIw0lMhLh2MTgeM3gZoBeEMC85atCFvCF2rKQRfo4/pYR9cjP2gJPQuxhjH5Rql6sKfY8fRY= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2015 00:21:08.2231 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1BFFO11HUB019 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 993 Lines: 29 The RX path in the interrupt handler released a lock unnecessarily. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index b189e600d4ab..544ea13e2e93 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -265,9 +265,7 @@ static irqreturn_t cdns_uart_isr(int irq, void *dev_id) uart_insert_char(port, isrstatus, CDNS_UART_IXR_OVERRUN, data, status); } - spin_unlock(&port->lock); tty_flip_buffer_push(&port->state->port); - spin_lock(&port->lock); } /* Dispatch an appropriate handler */ -- 2.6.2.3.ga463a5b -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/