Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756092AbbKDBNy (ORCPT ); Tue, 3 Nov 2015 20:13:54 -0500 Received: from mail-pa0-f45.google.com ([209.85.220.45]:32885 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755445AbbKDBNw (ORCPT ); Tue, 3 Nov 2015 20:13:52 -0500 Date: Tue, 3 Nov 2015 17:13:48 -0800 From: Brian Norris To: Yakir Yang Cc: Inki Dae , Andrzej Hajda , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Jingoo Han , Thierry Reding , Krzysztof Kozlowski , Rob Herring , Heiko Stuebner , Mark Yao , djkurtz@chromium.org, dianders@chromium.org, Gustavo Padovan , linux-samsung-soc@vger.kernel.org, Russell King , linux-rockchip@lists.infradead.org, Kishon Vijay Abraham I , javier@osg.samsung.com, Kukjin Kim , robherring2@gmail.com, devicetree@vger.kernel.org, Pawel Moll , Ian Campbell , Sean Paul , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, emil.l.velikov@gmail.com, linux-kernel@vger.kernel.org, Kumar Gala , ajaynumb@gmail.com, Andy Yan Subject: Re: [PATCH v9 10/17] phy: Add driver for rockchip Display Port PHY Message-ID: <20151104011348.GL7274@google.com> References: <1446020143-32645-1-git-send-email-ykk@rock-chips.com> <1446083918-30809-1-git-send-email-ykk@rock-chips.com> <20151103043827.GA17261@localhost> <563955E6.7000905@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <563955E6.7000905@rock-chips.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2179 Lines: 64 Hi Yakir, On Wed, Nov 04, 2015 at 08:48:38AM +0800, Yakir Yang wrote: > On 11/03/2015 12:38 PM, Brian Norris wrote: > >On Thu, Oct 29, 2015 at 09:58:38AM +0800, Yakir Yang wrote: > >(FYI, I came across this by inspection when comparing Heiko's > >'somewhat-stable' branch [1] with this series. The former brings up eDP > >fine on veyron-jaq, whereas this one doesn't yet, even with the above > >change. Still debugging the issue.) > > Hmm... I'm not sure whether your eDP screen have the hotplug signal, so I I believe hotplug is hooked up but... > think you can try to add "analogix,force-hpd" flag into > rk3288-veyron-jaq.dts > > &edp { > analogix,need-force-hpd; > } ...already tried, just in case. No luck. > If that changes couldn't fix the problem, guess you may need max the panel > power up delay time which pointed by Heiko. Like: > > Thanks, > - Yakir > > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > index 4fa5f69..546a506 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > @@ -82,6 +82,13 @@ static int analogix_dp_detect_hpd(struct > analogix_dp_device *dp) > */ > dev_dbg(dp->dev, "failed to get hpd plug status, try to > force hpd\n"); > > + /* > + * Hotplug signal would indicate the right time to operate > + * panel after poweron, but if the hotplug is missing, then > + * panel would need wait hundreds of milliseconds at here. > + */ > + mdelay(100); > + > analogix_dp_force_hpd(dp); > > if (analogix_dp_get_plug_in_status(dp) != 0) { I'll give that a try. Per Heiko's suggestion, I've already hacked around with adding delays in the regulator node, but this could give slightly different behavior. I doubt it'll help, but I'll let you know if it does. Regards, Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/