Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756156AbbKDC2M (ORCPT ); Tue, 3 Nov 2015 21:28:12 -0500 Received: from mail-lb0-f171.google.com ([209.85.217.171]:33051 "EHLO mail-lb0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755787AbbKDC2G (ORCPT ); Tue, 3 Nov 2015 21:28:06 -0500 MIME-Version: 1.0 In-Reply-To: <06282344-726E-49AD-936B-7BFF8F43B967@dilger.ca> References: <1446563847-14005-1-git-send-email-agruenba@redhat.com> <1446563847-14005-22-git-send-email-agruenba@redhat.com> <06282344-726E-49AD-936B-7BFF8F43B967@dilger.ca> Date: Wed, 4 Nov 2015 03:28:03 +0100 Message-ID: Subject: Re: [PATCH v13 21/51] ext4: Add richacl feature flag From: Andreas Gruenbacher To: Andreas Dilger Cc: Alexander Viro , "Theodore Ts'o" , Andreas Dilger , "J. Bruce Fields" , Jeff Layton , Trond Myklebust , Anna Schumaker , Dave Chinner , linux-ext4 , XFS Developers , LKML , linux-fsdevel , Linux NFS Mailing List , linux-cifs@vger.kernel.org, Linux API , "Aneesh Kumar K.V" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1126 Lines: 25 Andreas, On Wed, Nov 4, 2015 at 3:18 AM, Andreas Dilger wrote: > This patch confuses me. I thought the whole point of INCOMPAT_RICHACL > was that the filesystem should never, ever be mounted without ACL support > because the ACLs will get confused without it. In that case, it doesn't > make sense to have a mount option that _has_ to be specified to mount the > filesystem, and returns an error when trying to disable it. > > It makes more sense to just enable "acl" by default if INCOMPAT_RICHACL > is set in the superblock and not need the mount option at all. It's the commit message that's misleading here, I'll fix it. On richacl filesystems, the acl mount option is always on. It's only on POSIX ACL filesystems that the mount option can be used to turn POSIX ACLs off (which arguably wasn't such a good idea, but there we have it). Thanks, Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/