Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751480AbbKDFEA (ORCPT ); Wed, 4 Nov 2015 00:04:00 -0500 Received: from mail-bn1bon0133.outbound.protection.outlook.com ([157.56.111.133]:18528 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751252AbbKDFD4 convert rfc822-to-8bit (ORCPT ); Wed, 4 Nov 2015 00:03:56 -0500 From: Duan Andy To: Yibin Gong , "gregkh@linuxfoundation.org" , "edubezval@gmail.com" CC: "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v1] Revert "serial: imx: remove unbalanced clk_prepare" Thread-Topic: [PATCH v1] Revert "serial: imx: remove unbalanced clk_prepare" Thread-Index: AQHRFqzvw3anVa3xZk+Z7sXdmewgHp6LTqrw Date: Wed, 4 Nov 2015 05:03:53 +0000 Message-ID: References: <1446605898-27635-1-git-send-email-b38343@freescale.com> In-Reply-To: <1446605898-27635-1-git-send-email-b38343@freescale.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=fugang.duan@freescale.com; x-originating-ip: [199.59.230.102] x-microsoft-exchange-diagnostics: 1;DM2PR0301MB0782;5:SSXu5ttr6xfXrEbHOiO/1o62zz2aUpXpg8kMeordI1/VBkSBGj3qLWPWXFzlwKFZPEF+fc0i/PMAae1aUOXDyxlu2ur+oFhoAd9CE/BFKXMDGg+tzJBUdXmR+qITK1zSkOqaWg22OtHE03yUUbFbcA==;24:Bg3m7NKa13BpK9FNN9Fg5cBfv/aehNWnflD1l6uo3QzHYBOmH4bzkj2N6juUpV4Cbpu0g6gItBuIu9ALwMrZz0c65JdO+K683X0d2Xbw0rg=;20:P2xqw4n4YEmck9AHvvcIKQOg2pvqr1TU7zH912WO8JOnbbpyKqd2BQpw7/eB02ZowlzVDp8f60Pc0pmjFlFyKg== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0301MB0782; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(101931422205132); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(10201501046)(3002001);SRVR:DM2PR0301MB0782;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0301MB0782; x-forefront-prvs: 0750463DC9 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(377454003)(199003)(189002)(77096005)(102836002)(66066001)(122556002)(2501003)(2950100001)(10400500002)(86362001)(40100003)(575784001)(2900100001)(5001960100002)(33656002)(92566002)(189998001)(5004730100002)(5002640100001)(5007970100001)(97736004)(5001770100001)(87936001)(105586002)(106116001)(5008740100001)(11100500001)(99286002)(74316001)(19580395003)(106356001)(50986999)(54356999)(81156007)(76176999)(101416001)(2201001)(19580405001)(76576001)(5003600100002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM2PR0301MB0782;H:BN3PR0301MB1219.namprd03.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Nov 2015 05:03:53.1459 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0301MB0782 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3096 Lines: 68 From: Robin Gong Sent: Wednesday, November 04, 2015 10:58 AM > To: gregkh@linuxfoundation.org; edubezval@gmail.com > Cc: Duan Fugang-B38611; linux-serial@vger.kernel.org; linux- > kernel@vger.kernel.org > Subject: [PATCH v1] Revert "serial: imx: remove unbalanced clk_prepare" > > commit 9e7b399d6528 ("serial: imx: remove unbalanced clk_prepare"). > Otherwise below warning happen since there are some printk logs in > interrupt. > > [ 14.868319] udevd[501]: starting version 182 > [ 16.386107] random: nonblocking pool is initialized > [ 16.386123] ------------[ cut here ]------------ > [ 16.386140] WARNING: CPU: 0 PID: 501 at kernel/locking/mutex.c:868 > mutex_trylock+0x210/0x230() > [ 16.386146] DEBUG_LOCKS_WARN_ON(in_interrupt()) > [ 16.386149] Modules linked in: > [ 16.386157] CPU: 0 PID: 501 Comm: udevd Not tainted 4.3.0-rc1-00014- > gf843df8 #28 > [ 16.386160] Hardware name: Freescale i.MX6 SoloX (Device Tree) > [ 16.386165] Backtrace: > [ 16.386182] [] (dump_backtrace) from [] > (show_stack+0x18/0x1c) > [ 16.386192] r6:c0af1840 r5:00000000 r4:00000000 r3:00000000 > [ 16.386201] [] (show_stack) from [] > (dump_stack+0x8c/0xa4) > [ 16.386216] [] (dump_stack) from [] > (warn_slowpath_common+0x80/0xbc) > [ 16.386225] r6:c07b1ccc r5:00000009 r4:edcf5c60 r3:00000001 > [ 16.386234] [] (warn_slowpath_common) from [] > (warn_slowpath_fmt+0x38/0x40) > [ 16.386246] r8:c0564694 r7:eeb76880 r6:c13323ec r5:00000001 > r4:c0976990 > [ 16.386255] [] (warn_slowpath_fmt) from [] > (mutex_trylock+0x210/0x230) > [ 16.386261] r3:c0978f50 r2:c0976990 > [ 16.386264] r4:c0b29a70 > [ 16.386278] [] (mutex_trylock) from [] > (clk_prepare_lock+0x14/0xf4) > [ 16.386289] r8:c133000c r7:eeb76880 r6:00000037 r5:c12efbc8 > r4:eeb76880 > [ 16.386297] [] (clk_prepare_lock) from [] > (clk_prepare+0x18/0x38) > [ 16.386303] r5:c12efbc8 r4:eeb76880 > [ 16.386311] [] (clk_prepare) from [] > (imx_console_write+0x34/0x248) > [ 16.386317] r4:ee999c10 r3:c134a92c > [ 16.386329] [] (imx_console_write) from [] > (call_console_drivers.constprop.25+0xe0/0x104) > [ 16.386342] r10:c07b938c r9:00000000 r8:c133000c r7:00000037 > r6:edcf4000 r5:c12ef6c0 > [ 16.386345] r4:c0afef38 > [ 16.386355] [] (call_console_drivers.constprop.25) from > [] (console_unlock+0x3fc/0x57c) > [ 16.386367] r10:c132fff0 r9:00000100 r8:00000037 r7:00000000 > r6:00000005 r5:c12f4df0 > > Signed-off-by: Robin Gong > --- > drivers/tty/serial/imx.c | 20 ++++++++++++++------ > 1 file changed, 14 insertions(+), 6 deletions(-) I remember there had patch for this. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/