Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932293AbbKDIBM (ORCPT ); Wed, 4 Nov 2015 03:01:12 -0500 Received: from [119.145.14.66] ([119.145.14.66]:37148 "EHLO szxga03-in.huawei.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753732AbbKDIBJ (ORCPT ); Wed, 4 Nov 2015 03:01:09 -0500 Subject: Re: [PATCH RFC 7/7] irqchip: [Example] dummy wired interrupt/MSI bridge driver To: Marc Zyngier , Thomas Gleixner , Jiang Liu , Jason Cooper References: <1444923568-17413-1-git-send-email-marc.zyngier@arm.com> <1444923568-17413-8-git-send-email-marc.zyngier@arm.com> CC: , , From: "majun (F)" Message-ID: <5639BB10.1090108@huawei.com> Date: Wed, 4 Nov 2015 16:00:16 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1444923568-17413-8-git-send-email-marc.zyngier@arm.com> Content-Type: text/plain; charset="gbk" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.177.235.245] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.5639BB16.00E4,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 5e48a6f90e277d899df5ac9a5afe0dad Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1982 Lines: 78 Hi Marc: ?? 2015/10/15 23:39, Marc Zyngier ะด??: > In order to demonstrate how to put together a wire/MSI bridge, > add a dummy driver that doesn't do anything at all, except > for allocating interrupts. > > It comes together with an even more stupid client driver that > allocates an interrupt and dump the hierarchy of that interrupt. > > Signed-off-by: Marc Zyngier > --- [...] > + > +static int msichip_domain_alloc(struct irq_domain *domain, unsigned int virq, > + unsigned int nr_irqs, void *arg) > +{ > + int i, err; > + irq_hw_number_t hwirq; > + unsigned int type; > + struct irq_fwspec *fwspec = arg; > + void *data; > + > + err = msichip_domain_translate(domain, fwspec, &hwirq, &type); > + if (err) > + return err; > + .translate function already called once in irq_domain_translate(), I think we don't need call this fucntion one more time here. > + err = platform_msi_domain_alloc(domain, virq, nr_irqs); > + if (err) > + return err; > + > + data = platform_msi_get_host_data(domain); > + for (i = 0; i < nr_irqs; i++) > + irq_domain_set_hwirq_and_chip(domain, virq + i, hwirq + i, > + &msichip_chip, data); > + > + return 0; > +} > + [...] > + > +static struct platform_driver msichip_driver = { > + .driver = { > + .name = "msichip", > + .of_match_table = msichip_of_match, > + }, > + .probe = msichip_probe, > +}; > +/* Do not define this as an irqchip */ > +module_platform_driver(msichip_driver); > + > + I think,for a interrupt controller, msichip driver initialization maybe is too late for some devices which connect to this irqchip if we use module_platform_driver. So, how about use the arch_initcall to register the msichip driver? Thanks! Ma Jun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/