Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754980AbbKDIJu (ORCPT ); Wed, 4 Nov 2015 03:09:50 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:45559 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751403AbbKDIJq (ORCPT ); Wed, 4 Nov 2015 03:09:46 -0500 X-AuditID: cbfec7f4-f79c56d0000012ee-9e-5639bd472c4f Subject: Re: [PATCH v5 1/4] Documentation: dt-bindings: Describe SROMc configuration To: Pavel Fedin , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <9a1edb15c06e27fa1fba5773c937e3a3d363c32a.1446542020.git.p.fedin@samsung.com> Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Kukjin Kim From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <5639BD40.4020000@samsung.com> Date: Wed, 04 Nov 2015 17:09:36 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-version: 1.0 In-reply-to: <9a1edb15c06e27fa1fba5773c937e3a3d363c32a.1446542020.git.p.fedin@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkkeLIzCtJLcpLzFFi42I5/e/4VV33vZZhBlMXCVjMP3KO1aL/zUJW i3OvVjJavH5haNH/+DWzxabH11gtLu+aw2Yx4/w+Joul1y8yWby6tIrNYsL0tSwWrXuPsDvw eKyZt4bR43JfL5PHyuVf2Dw2repk89i8pN6jb8sqRo/Pm+QC2KO4bFJSczLLUov07RK4Mvad Os5ScE6h4m7vEsYGxk6JLkZODgkBE4kF51uYIWwxiQv31rN1MXJxCAksZZS4fuYRC4TzhVFi 7rSrYFXCAmES01uamUESIgJrGCWWnzvICJIQEmhjlDh+PQ0kwSzwgFHi/uUmsASbgLHE5uVL 2CB2yEn0dk9iAbF5BbQkPjS/YAKxWQRUJT4cOwVmiwpESEyc0MAKUSMo8WPyPbB6ToEYiTnb HgPVcAAt0JO4f1ELJMwsIC+xec1b5gmMgrOQdMxCqJqFpGoBI/MqRtHU0uSC4qT0XEO94sTc 4tK8dL3k/NxNjJAI+rKDcfExq0OMAhyMSjy8Nxgtw4RYE8uKK3MPMUpwMCuJ8DYtAQrxpiRW VqUW5ccXleakFh9ilOZgURLnnbvrfYiQQHpiSWp2ampBahFMlomDU6qBkXv7XrePilsOMCVL SfrZa90sL0zvEzwfr3Nt9Q8WSa3lt9s/MxtbVJ88cnzzz03f606YqtTMFjhxkM3IpEngotWR +o0X33/7Kixot2RdQV/6tP3Tgh4d0BbdEa1rpvc1o+9t+umEhTHSd2TYRIK119QEFj85o/WJ 88D+sgmTe1eW68w32ajdqsRSnJFoqMVcVJwIAHF2yVicAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4303 Lines: 121 On 03.11.2015 18:16, Pavel Fedin wrote: > Add documentation for new subnode properties, allowing bank configuration. > Based on u-boot implementation, but heavily reworked. Please mention also fixing the size of mapped memory in in the example. > > Signed-off-by: Pavel Fedin > --- > .../bindings/arm/samsung/exynos-srom.txt | 68 +++++++++++++++++++++- > 1 file changed, 66 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-srom.txt b/Documentation/devicetree/bindings/arm/samsung/exynos-srom.txt > index 33886d5..ee378ca 100644 > --- a/Documentation/devicetree/bindings/arm/samsung/exynos-srom.txt > +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-srom.txt > @@ -5,8 +5,72 @@ Required properties: > > - reg: offset and length of the register set > > -Example: > +- #address-cells: Must be set to 2 to allow memory address translation > + > +- #size-cells: Must be set to 1 to allow CS address passing > + > +- ranges: Must be set up to reflect the memory layout with four integer values > + per bank: > + 0 > + These are mentioned as required but actually they shouldn't be, if there are no peripherals. By making them required you would be breaking ABI. I see that actually the ABI is not broken by the driver so maybe just add a separate optional section for subdevices. In that section you would described required attributes and subnodes. > +Sub-nodes: > +The SROM controller can be used to attach external peripherials. In this case s/peripherials/peripherals/ > +device nodes should be added as subnodes to the SROMc node. These subnodes, > +except regular device specification, should contain the following properties, > +describing configuration of the relevant SROM bank: > + > +Required properties: > +- reg: bank number, base address (relative to start of the bank) and size of > + the memory mapped for the device. Note that base address will be > + typically 0 as this is the start of the bank. > + > +- samsung,srom-timing : array of 6 integers, specifying bank timings in the > + following order: Tacp, Tcah, Tcoh, Tacc, Tcos, Tacs. > + Each value is specified in cycles (0 - 15) and has the > + following meaning: > + Tacp : Page mode access cycle at Page mode > + Tcah : Address holding time after CSn > + Tcoh : Chip selection hold on OEn > + Tacc : Access cycle This one has values 1-32 clock cycles > + Tcos : Chip selection set-up before OEn > + Tacs : Address set-up before CSn > + > +Optional properties: > +- reg-io-width : data width in bytes (1 or 2). If omitted, default of 1 is used. > + > +- samsung,srom-page-mode : page mode configuration for the bank: > + 0 - normal (one data) > + 1 - four data > + If omitted, default of 0 is used. > + > +Example: basic definition, no banks are configured > + sromc@12570000 { > + compatible = "samsung,exynos-srom"; > + reg = <0x12570000 0x14>; > + }; > + > +Example: SROMc with smsc 911x ethernet chip on bank 3 Maybe: s/smsc 911x ethernet/SMSC911x Ethernet/ Best regards, Krzysztof > sromc@12570000 { > + #address-cells = <2>; > + #size-cells = <1>; > + ranges = <0 0 0x04000000 0x20000 // Bank0 > + 1 0 0x05000000 0x20000 // Bank1 > + 2 0 0x06000000 0x20000 // Bank2 > + 3 0 0x07000000 0x20000>; // Bank3 > + > compatible = "samsung,exynos-srom"; > - reg = <0x12570000 0x10>; > + reg = <0x12570000 0x14>; > + > + ethernet@3 { > + compatible = "smsc,lan9115"; > + reg = <3 0 0x10000>; // Bank 3, offset = 0 > + phy-mode = "mii"; > + interrupt-parent = <&gpx0>; > + interrupts = <5 8>; > + reg-io-width = <2>; > + smsc,irq-push-pull; > + smsc,force-internal-phy; > + > + samsung,srom-config = <1 9 12 1 9 1 1>; > + }; > }; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/