Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932530AbbKDJEb (ORCPT ); Wed, 4 Nov 2015 04:04:31 -0500 Received: from mail-ig0-f194.google.com ([209.85.213.194]:35147 "EHLO mail-ig0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932390AbbKDJE1 (ORCPT ); Wed, 4 Nov 2015 04:04:27 -0500 MIME-Version: 1.0 In-Reply-To: <1444813494-14985-1-git-send-email-javier@osg.samsung.com> References: <1444813494-14985-1-git-send-email-javier@osg.samsung.com> Date: Wed, 4 Nov 2015 10:04:26 +0100 Message-ID: Subject: Re: [PATCH] mtd: Make MTD_BCM47XXSFLASH to depend on MIPS From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: Javier Martinez Canillas Cc: Linux Kernel Mailing List , Fengguang Wu , Michael Ellerman , Luis de Bethencourt , Jeremy Kerr , Neelesh Gupta , "linux-mtd@lists.infradead.org" , Brian Norris , David Woodhouse , Cyril Bur Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1380 Lines: 27 On 14 October 2015 at 11:04, Javier Martinez Canillas wrote: > The bcm47xxsflash driver uses the KSEG0ADDR() function to map an address > to a certain kernel segment. But that is only defined if the MIPS config > symbol is enabled. The driver does not have an explicit dependency on it > and relies on a transitive dependency relation: > > MTD_BCM47XXSFLASH -> BCMA_SFLASH -> BCMA_DRIVER_MIPS -> BCMA && MIPS > > But BCMA_SFLASH and BCMA_DRIVER_MIPS have only runtime and not buildtime > dependency with MIPS so can be changed to be built test using the config > COMPILE_TEST symbol. But that would make MTD_BCM47XXSFLASH be built with > MIPS not enabled and cause the following build error: > > drivers/mtd/devices//bcm47xxsflash.c: In function 'bcm47xxsflash_read': > drivers/mtd/devices//bcm47xxsflash.c:112:2: error: implicit declaration of function 'KSEG0ADDR' [-Werror=implicit-function-declaration] > memcpy_fromio(buf, (void __iomem *)KSEG0ADDR(b47s->window + from), I think we're not really supposed to use KSEG0ADDR anyway. What about replacing it with ioremap_nocache? Sorry for the late reply. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/