Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964794AbbKDJZf (ORCPT ); Wed, 4 Nov 2015 04:25:35 -0500 Received: from down.free-electrons.com ([37.187.137.238]:52098 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932241AbbKDJZc (ORCPT ); Wed, 4 Nov 2015 04:25:32 -0500 Date: Wed, 4 Nov 2015 10:25:29 +0100 From: Alexandre Belloni To: Soren Brinkmann Cc: Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: Group Kconfig entries by vendor Message-ID: <20151104092529.GX22331@piout.net> References: <1446621226-28429-1-git-send-email-soren.brinkmann@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1446621226-28429-1-git-send-email-soren.brinkmann@xilinx.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 6149 Lines: 195 On 03/11/2015 at 23:13:46 -0800, Soren Brinkmann wrote : > The RTC entries are mostly grouped by vendor. Move the few outliers in > place. > Also, change the one occurrence of 'nxp' to 'NXP' to make all NXP > entries consistent. > Yeah, I've been contemplating reordering the Kconfig, the main issue being that Philips and NXP is the same entity. And also, we have RTCs manufactured by different vendors that use the same chip (Abracon/Epson/Philips/Microcrystal) so I'm not sure what is clearer for the end user :) > Signed-off-by: Soren Brinkmann > --- > drivers/rtc/Kconfig | 90 ++++++++++++++++++++++++++--------------------------- > 1 file changed, 45 insertions(+), 45 deletions(-) > > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig > index 2a524244afec..ea7f43f12f69 100644 > --- a/drivers/rtc/Kconfig > +++ b/drivers/rtc/Kconfig > @@ -325,16 +325,6 @@ config RTC_DRV_MAX77686 > This driver can also be built as a module. If so, the module > will be called rtc-max77686. > > -config RTC_DRV_RK808 > - tristate "Rockchip RK808 RTC" > - depends on MFD_RK808 > - help > - If you say yes here you will get support for the > - RTC of RK808 PMIC. > - > - This driver can also be built as a module. If so, the module > - will be called rk808-rtc. > - > config RTC_DRV_MAX77802 > tristate "Maxim 77802 RTC" > depends on MFD_MAX77686 > @@ -345,6 +335,16 @@ config RTC_DRV_MAX77802 > This driver can also be built as a module. If so, the module > will be called rtc-max77802. > > +config RTC_DRV_RK808 > + tristate "Rockchip RK808 RTC" > + depends on MFD_RK808 > + help > + If you say yes here you will get support for the > + RTC of RK808 PMIC. > + > + This driver can also be built as a module. If so, the module > + will be called rk808-rtc. > + > config RTC_DRV_RS5C372 > tristate "Ricoh R2025S/D, RS5C372A/B, RV5C386, RV5C387A" > help > @@ -391,16 +391,6 @@ config RTC_DRV_X1205 > This driver can also be built as a module. If so, the module > will be called rtc-x1205. > > -config RTC_DRV_PALMAS > - tristate "TI Palmas RTC driver" > - depends on MFD_PALMAS > - help > - If you say yes here you get support for the RTC of TI PALMA series PMIC > - chips. > - > - This driver can also be built as a module. If so, the module > - will be called rtc-palma. > - > config RTC_DRV_PCF2127 > tristate "NXP PCF2127" > help > @@ -419,6 +409,14 @@ config RTC_DRV_PCF8523 > This driver can also be built as a module. If so, the module > will be called rtc-pcf8523. > > +config RTC_DRV_PCF85063 > + tristate "NXP PCF85063" > + help > + If you say yes here you get support for the PCF85063 RTC chip > + > + This driver can also be built as a module. If so, the module > + will be called rtc-pcf85063. > + > config RTC_DRV_PCF8563 > tristate "Philips PCF8563/Epson RTC8564" > help > @@ -429,14 +427,6 @@ config RTC_DRV_PCF8563 > This driver can also be built as a module. If so, the module > will be called rtc-pcf8563. > > -config RTC_DRV_PCF85063 > - tristate "nxp PCF85063" > - help > - If you say yes here you get support for the PCF85063 RTC chip > - > - This driver can also be built as a module. If so, the module > - will be called rtc-pcf85063. > - > config RTC_DRV_PCF8583 > tristate "Philips PCF8583" > help > @@ -501,6 +491,16 @@ config RTC_DRV_TWL4030 > This driver can also be built as a module. If so, the module > will be called rtc-twl. > > +config RTC_DRV_PALMAS > + tristate "TI Palmas RTC driver" > + depends on MFD_PALMAS > + help > + If you say yes here you get support for the RTC of TI PALMA series PMIC > + chips. > + > + This driver can also be built as a module. If so, the module > + will be called rtc-palma. > + > config RTC_DRV_TPS6586X > tristate "TI TPS6586X RTC driver" > depends on MFD_TPS6586X > @@ -681,15 +681,6 @@ config RTC_DRV_DS1390 > This driver can also be built as a module. If so, the module > will be called rtc-ds1390. > > -config RTC_DRV_MAX6902 > - tristate "Maxim MAX6902" > - help > - If you say yes here you will get support for the > - Maxim MAX6902 SPI RTC chip. > - > - This driver can also be built as a module. If so, the module > - will be called rtc-max6902. > - > config RTC_DRV_R9701 > tristate "Epson RTC-9701JE" > help > @@ -699,6 +690,14 @@ config RTC_DRV_R9701 > This driver can also be built as a module. If so, the module > will be called rtc-r9701. > > +config RTC_DRV_RX4581 > + tristate "Epson RX-4581" > + help > + If you say yes here you will get support for the Epson RX-4581. > + > + This driver can also be built as a module. If so the module > + will be called rtc-rx4581. > + > config RTC_DRV_RS5C348 > tristate "Ricoh RS5C348A/B" > help > @@ -708,6 +707,15 @@ config RTC_DRV_RS5C348 > This driver can also be built as a module. If so, the module > will be called rtc-rs5c348. > > +config RTC_DRV_MAX6902 > + tristate "Maxim MAX6902" > + help > + If you say yes here you will get support for the > + Maxim MAX6902 SPI RTC chip. > + > + This driver can also be built as a module. If so, the module > + will be called rtc-max6902. > + > config RTC_DRV_DS3234 > tristate "Maxim/Dallas DS3234" > help > @@ -726,14 +734,6 @@ config RTC_DRV_PCF2123 > This driver can also be built as a module. If so, the module > will be called rtc-pcf2123. > > -config RTC_DRV_RX4581 > - tristate "Epson RX-4581" > - help > - If you say yes here you will get support for the Epson RX-4581. > - > - This driver can also be built as a module. If so the module > - will be called rtc-rx4581. > - > config RTC_DRV_MCP795 > tristate "Microchip MCP795" > help > -- > 2.6.2.3.ga463a5b > -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/