Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965506AbbKDODQ (ORCPT ); Wed, 4 Nov 2015 09:03:16 -0500 Received: from mga14.intel.com ([192.55.52.115]:46606 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965184AbbKDODP (ORCPT ); Wed, 4 Nov 2015 09:03:15 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,243,1444719600"; d="scan'208";a="593886021" Subject: Re: [PATCH 0/3] cpuidle: small improvements & fixes for menu governor To: Joe Perches , Rik van Riel , linux-kernel@vger.kernel.org References: <1446072416-13622-1-git-send-email-riel@redhat.com> <56392FA5.5080205@intel.com> <563936B4.4030308@redhat.com> <56393D51.6090101@intel.com> <1446620168.21133.29.camel@perches.com> Cc: arjan@linux.intel.com, khilman@ti.com, len.brown@intel.com, daniel.lezcano@linaro.org, javi.merino@arm.com, tuukka.tikkanen@linaro.org From: "Rafael J. Wysocki" Organization: Intel Technology Poland Sp. z o. o., KRS 101882, ul. Slowackiego 173, 80-298 Gdansk Message-ID: <563A0FF3.40604@intel.com> Date: Wed, 4 Nov 2015 15:02:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1446620168.21133.29.camel@perches.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3514 Lines: 93 On 11/4/2015 7:56 AM, Joe Perches wrote: > On Wed, 2015-11-04 at 00:03 +0100, Rafael J. Wysocki wrote: >> On 11/3/2015 11:35 PM, Rik van Riel wrote: >>> On 11/03/2015 05:05 PM, Rafael J. Wysocki wrote: >>>> On 10/28/2015 11:46 PM, riel@redhat.com wrote: >>>>> While working on a paravirt cpuidle driver for KVM guests, I >>>>> noticed a number of small logic errors in the menu governor >>>>> code. >>>>> >>>>> These patches should get rid of some artifacts that can break >>>>> the logic in the menu governor under certain corner cases, and >>>>> make idle state selection work better on CPUs with long C1 exit >>>>> latencies. >>>>> >>>>> I have not seen any adverse effects with them in my (quick) >>>>> tests. As expected, they do not seem to do much on systems with >>>>> many power states and very low C1 exit latencies and target >>>>> residencies. >>>>> >>>> Sorry for the trouble, but can you please resend the series with >>>> CCs to >>>> linux-pm@vger.kernel.org? That will make it way easier to handle >>>> for me. >>> Not a problem. Done. >>> >>> What change do I need to send in to ensure that the >>> linux-pm mailing list shows up in get_maintainer.pl >>> output? >>> >>> $ ./scripts/get_maintainer.pl -f drivers/cpuidle/governors/menu.c >>> "Rafael J. Wysocki" >>> (commit_signer:4/7=57%,authored:1/7=14%,added_lines:2/19=11%,remove >>> d_lines:2/28=7%) >>> Daniel Lezcano >>> (commit_signer:3/7=43%,authored:1/7=14%,added_lines:1/19=5%) >>> Rik van Riel >>> (commit_signer:3/7=43%,authored:3/7=43%,added_lines:5/19=26%,remove >>> d_lines:3/28=11%) >>> Len Brown >>> (commit_signer:1/7=14%,authored:1/7=14%,added_lines:10/19=53%,remov >>> ed_lines:15/28=54%) >>> "Peter Zijlstra (Intel)" >>> (commit_signer:1/7=14%) >>> Javi Merino >>> (authored:1/7=14%,added_lines:1/19=5%,removed_lines:7/28=25%) >>> linux-kernel@vger.kernel.org (open list) >>> >> I'm not sure why it doesn't show up in there. >> If you look at MAINTAINERS under CPUIDLE DRIVERS, linux-pm is >> actually listed there. > Because the pattern is just the files in the top level directory > of drivers/cpuidle and not any files in any directory below > > From the MAINTAINERS pattern descriptions: > > F: Files and directories with wildcard patterns. > A trailing slash includes all files and subdirectory files. > F: drivers/net/ all files in and below > drivers/net > F: drivers/net/* all files in drivers/net, but > not below > >> Maybe the answer is that get_maintainer.pl needs to be fixed ... > Nope, the MAINTAINERS - CPUIDLE DRIVERS entry does though. OK, I see. Care to send this patch with a proper changelog/sign-off? > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 77ed3a0..8bd5c7e 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -3004,7 +3004,7 @@ M: Daniel Lezcano > L: linux-pm@vger.kernel.org > S: Maintained > T: git git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git > -F: drivers/cpuidle/* > +F: drivers/cpuidle/ > F: include/linux/cpuidle.h > > CPUID/MSR DRIVER > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/