Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030251AbbKDOlh (ORCPT ); Wed, 4 Nov 2015 09:41:37 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:47277 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932631AbbKDOlf (ORCPT ); Wed, 4 Nov 2015 09:41:35 -0500 Date: Wed, 4 Nov 2015 14:41:12 +0000 From: Mark Brown To: Vignesh R Cc: Tony Lindgren , Michal Suchanek , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org Message-ID: <20151104144112.GJ1717@sirena.org.uk> References: <1446545174-14193-1-git-send-email-vigneshr@ti.com> <1446545174-14193-3-git-send-email-vigneshr@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="J2uG6jHjFLimDtBY" Content-Disposition: inline In-Reply-To: <1446545174-14193-3-git-send-email-vigneshr@ti.com> X-Cookie: He who hesitates is sometimes saved. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 92.40.248.4 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v2 2/5] spi: spi-ti-qspi: add mmap mode read support X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1436 Lines: 40 --J2uG6jHjFLimDtBY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 03, 2015 at 03:36:11PM +0530, Vignesh R wrote: > + ti_qspi_enable_memory_map(spi); > + ti_qspi_setup_mmap_read(spi, read_opcode, addr_width, > + dummy_bytes); > + memcpy_fromio(buf, qspi->mmap_base + from, len); > + *retlen = len; > + ti_qspi_disable_memory_map(spi); We'll be constantly enabling and disabling memory mapping with this. I'm not sure that's a meaningful cost given that it doesn't actually remap anything but rather just switches hardware modes, we can always optimise it later if it is. --J2uG6jHjFLimDtBY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWOhkHAAoJECTWi3JdVIfQrmcH/RSv12IrXq3lgkOLUxuYhAZj YOjt8j86vy59wUu+5W/9xdgcAnrL3mOWhJowkBCgY6108OkKhlgxBgnvmqGbQu8V Qu2sKe4sPQp/rnajAKPL8epEjegIkeE3mumUKN9tbKxraf8uVVS7thibwPPY0qwm m/OFxiu6+9RLHJ+Q1iBXHDV7ePbJU+eRl6+BKaWYMjHfgW9gw8ktZFX6hjnTG0vC 6FcOCp1kdcgOn5GDwUthIyQOzHqtLv7qL+SkSLEeMdFG12FPyX5sN/k/c0WakBIw qC2rWHcTTfRHy/o1XZ/oM6osCtkRBaglWeUpXXVg5KTMZHgONyume4GHLMIVAAc= =vwZN -----END PGP SIGNATURE----- --J2uG6jHjFLimDtBY-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/