Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030365AbbKDPB3 (ORCPT ); Wed, 4 Nov 2015 10:01:29 -0500 Received: from mx2.suse.de ([195.135.220.15]:53113 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965576AbbKDPB0 (ORCPT ); Wed, 4 Nov 2015 10:01:26 -0500 From: Vlastimil Babka To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Joonsoo Kim , Minchan Kim , Sasha Levin , "Kirill A. Shutemov" , Mel Gorman , Vlastimil Babka Subject: [PATCH 1/5] mm, page_owner: print migratetype of a page, not pageblock Date: Wed, 4 Nov 2015 16:00:57 +0100 Message-Id: <1446649261-27122-2-git-send-email-vbabka@suse.cz> X-Mailer: git-send-email 2.6.2 In-Reply-To: <1446649261-27122-1-git-send-email-vbabka@suse.cz> References: <1446649261-27122-1-git-send-email-vbabka@suse.cz> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1404 Lines: 36 The information in /sys/kernel/debug/page_owner includes the migratetype declared during the page allocation via gfp_flags. This is also checked against the pageblock's migratetype, and reported as Fallback allocation if these two differ (although in fact fallback allocation is not the only reason why they can differ). However, the migratetype actually printed is the one of the pageblock, not of the page itself, so it's the same for all pages in the pageblock. This is apparently a bug, noticed when working on other page_owner improvements. Fixed. Signed-off-by: Vlastimil Babka --- mm/page_owner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_owner.c b/mm/page_owner.c index 983c3a1..a9f16b8 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -113,7 +113,7 @@ print_page_owner(char __user *buf, size_t count, unsigned long pfn, "PFN %lu Block %lu type %d %s Flags %s%s%s%s%s%s%s%s%s%s%s%s\n", pfn, pfn >> pageblock_order, - pageblock_mt, + page_mt, pageblock_mt != page_mt ? "Fallback" : " ", PageLocked(page) ? "K" : " ", PageError(page) ? "E" : " ", -- 2.6.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/