Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965686AbbKDQHP (ORCPT ); Wed, 4 Nov 2015 11:07:15 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:33218 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753556AbbKDQHM (ORCPT ); Wed, 4 Nov 2015 11:07:12 -0500 MIME-Version: 1.0 In-Reply-To: <20151104004439.GB4650@malice.jf.intel.com> References: <20151104004439.GB4650@malice.jf.intel.com> Date: Wed, 4 Nov 2015 09:07:10 -0700 Message-ID: Subject: Re: [PATCH] toshiba_acpi: Initialize hotkey_event_type variable From: Azael Avalos To: Darren Hart Cc: "platform-driver-x86@vger.kernel.org" , "linux-kernel@vger.kernel.org" , stable@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1806 Lines: 52 Hi Darren, 2015-11-03 17:44 GMT-07:00 Darren Hart : > On Sun, Nov 01, 2015 at 07:30:30PM -0700, Azael Avalos wrote: >> Commit 23f8f4326a15 ("toshiba_acpi: Fix hotkeys registration on some >> toshiba models") fixed an issue on some laptops regarding hotkeys >> registration, however, if failed to address the initialization of the >> hotkey_event_type variable, and thus, it can lead to potential >> unwanted effects as the variable is being checked. >> >> This patch initializes such variable to avoid such unwanted effects. >> >> Cc: # 4.1+ >> Signed-off-by: Azael Avalos >> --- >> Darren, >> >> Sorry for sending this patch this late, I had a really busy week :-( > > It's a trivial patch, so I'm not concerned with the timing. Thanks for getting > it out! > > Unfortunately, it doesn't apply and appears to be whitespace mangled. Checkpatch > complains and tabs appear to have been replaced with spaces. Please check your > send mail mechanism and resend - possibly using git-send-email or something like > mutt -H PATCHNAME. Try sending to yourself first and verifying you can apply it. Ughh, sorry about this, I sent this email directly instead of git-send-email, so the copy-paste might have changed something. The version of git I'm currently using parses the stable address as stable@vger.kernel.org#4.1+ and gsmtp complains about a malformed address... I'll try to resend this patch ASAP. > > Thanks, > Cheers Azael -- -- El mundo apesta y vosotros apestais tambien -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/