Date: Wed, 4 Nov 2015 09:32:17 -0800
From: Davidlohr Bueso <dave@stgolabs.net>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        linux-kernel@vger.kernel.org, George Spelvin <linux@horizon.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Manfred Spraul <manfred@colorfullife.com>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] ipc/msg: Implement lockless pipelined wakeups
Message-ID: <20151104173217.GA15994@linux-uzut.site>
References: <1446563009-9076-1-git-send-email-bigeasy@linutronix.de>
 <20151104115538.GK17308@twins.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20151104115538.GK17308@twins.programming.kicks-ass.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 823
Lines: 23

On Wed, 04 Nov 2015, Peter Zijlstra wrote:

>On Tue, Nov 03, 2015 at 04:03:29PM +0100, Sebastian Andrzej Siewior wrote:
>
>> -	struct msg_msg		*volatile r_msg;
>> +	struct msg_msg		*r_msg;
>
>> +				wake_q_add(wake_q, msr->r_tsk);
>>  				msr->r_msg = msg;
>> +				/*
>> +				 * Rely on the implicit cmpxchg barrier from
>> +				 * wake_q_add such that we can ensure that
>
>Davidlohr, didn't you want to make that cmpxchg_relaxed() or
>cmpxchg_release() ?

Right, I had forgotten about that. iirc we ended up deciding to fully
relax the cmpxchg and update the callers instead.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/