Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030798AbbKDSVT (ORCPT ); Wed, 4 Nov 2015 13:21:19 -0500 Received: from mail-pa0-f52.google.com ([209.85.220.52]:32993 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030641AbbKDSVR (ORCPT ); Wed, 4 Nov 2015 13:21:17 -0500 Message-ID: <563A4C9A.7000002@linaro.org> Date: Wed, 04 Nov 2015 10:21:14 -0800 From: "Shi, Yang" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Xi Wang , Zi Shen Lim CC: Catalin Marinas , stable@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Alexei Starovoitov Subject: Re: [PATCH] arm64: bpf: fix div-by-zero case References: <1446620204-4228-1-git-send-email-zlim.lnx@gmail.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1477 Lines: 41 On 11/3/2015 11:04 PM, Xi Wang wrote: > On Tue, Nov 3, 2015 at 10:56 PM, Zi Shen Lim wrote: >> case BPF_ALU | BPF_DIV | BPF_X: >> case BPF_ALU64 | BPF_DIV | BPF_X: >> + { >> + const u8 r0 = bpf2a64[BPF_REG_0]; >> + >> + /* if (src == 0) return 0 */ >> + jmp_offset = 3; /* skip ahead to else path */ >> + check_imm19(jmp_offset); >> + emit(A64_CBNZ(is64, src, jmp_offset), ctx); >> + emit(A64_MOVZ(1, r0, 0, 0), ctx); >> + jmp_offset = epilogue_offset(ctx); >> + check_imm26(jmp_offset); >> + emit(A64_B(jmp_offset), ctx); >> + /* else */ >> emit(A64_UDIV(is64, dst, dst, src), ctx); >> break; >> + } >> case BPF_ALU | BPF_MOD | BPF_X: >> case BPF_ALU64 | BPF_MOD | BPF_X: > > BPF_MOD might need the same fix. Agreed, and we may need add one more test cases in test_bpf module to cover MOD? Yang > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/