Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965695AbbKDSWa (ORCPT ); Wed, 4 Nov 2015 13:22:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36248 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965488AbbKDSW2 (ORCPT ); Wed, 4 Nov 2015 13:22:28 -0500 Date: Wed, 4 Nov 2015 20:18:35 +0100 From: Oleg Nesterov To: Andrew Morton , Dmitry Vyukov Cc: Roland McGrath , amanieu@gmail.com, pmoore@redhat.com, Ingo Molnar , vdavydov@parallels.com, qiaowei.ren@intel.com, dave@stgolabs.net, palmer@dabbelt.com, LKML , syzkaller , Kostya Serebryany , Alexander Potapenko , Sasha Levin Subject: [PATCH 0/1] (Was: WARNING in task_participate_group_stop) Message-ID: <20151104191804.GA20578@redhat.com> References: <20151102151333.GA17152@redhat.com> <20151102163654.GA18804@redhat.com> <20151102180624.GA24361@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151102180624.GA24361@redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 953 Lines: 30 On 11/02, Oleg Nesterov wrote: > > and I think this should be fixed anyway, if nothing else to make this logic more > correct. Yes, please see the patch. > I'll try to recheck this all later. I found more problems, will try to send the fixes/cleanups tomorrow... do_signal_stop() is buggy, a multi-threaded exec can miss SIGSTOP. task_participate_group_stop() and prepare_signal() are buggy. We must not clear UNKILLABLE when we set STOPPED/CONTINUED. signal_group_exit() can probably die, it was added before we had fatal_signal_pending(). This reminds that we should finally remove signal_pending() check in fatal_signal_pending(). And change force_sig_info() to take ->ptrace into account. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/