Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965619AbbKDUI1 (ORCPT ); Wed, 4 Nov 2015 15:08:27 -0500 Received: from mail-wi0-f180.google.com ([209.85.212.180]:36604 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965309AbbKDUI0 (ORCPT ); Wed, 4 Nov 2015 15:08:26 -0500 From: LABBE Corentin To: peppe.cavallaro@st.com Cc: LABBE Corentin , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH] net: stmmac: remove unneeded phy_iface variable Date: Wed, 4 Nov 2015 21:08:12 +0100 Message-Id: <1446667692-6182-1-git-send-email-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.4.10 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1594 Lines: 43 The variable phy_iface is double-initialized and finally is not necessary at all. Reported-by: coverity (CID 1271141) Signed-off-by: LABBE Corentin --- drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c index 11baa4b..26a11b7 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c @@ -354,11 +354,9 @@ static int gmac_clk_init(struct rk_priv_data *bsp_priv) static int gmac_clk_enable(struct rk_priv_data *bsp_priv, bool enable) { - int phy_iface = phy_iface = bsp_priv->phy_iface; - if (enable) { if (!bsp_priv->clk_enabled) { - if (phy_iface == PHY_INTERFACE_MODE_RMII) { + if (bsp_priv->phy_iface == PHY_INTERFACE_MODE_RMII) { if (!IS_ERR(bsp_priv->mac_clk_rx)) clk_prepare_enable( bsp_priv->mac_clk_rx); @@ -390,7 +388,7 @@ static int gmac_clk_enable(struct rk_priv_data *bsp_priv, bool enable) } } else { if (bsp_priv->clk_enabled) { - if (phy_iface == PHY_INTERFACE_MODE_RMII) { + if (bsp_priv->phy_iface == PHY_INTERFACE_MODE_RMII) { if (!IS_ERR(bsp_priv->mac_clk_rx)) clk_disable_unprepare( bsp_priv->mac_clk_rx); -- 2.4.10 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/