Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965617AbbKDVlX (ORCPT ); Wed, 4 Nov 2015 16:41:23 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:49715 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965372AbbKDVlW convert rfc822-to-8bit (ORCPT ); Wed, 4 Nov 2015 16:41:22 -0500 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, Russell King , linux-kernel@vger.kernel.org Subject: Re: [RESEND][PATCH] ARM: debug: add support for Palmchip 16550-like UART References: <1445950678-16097-1-git-send-email-mans@mansr.com> <3941204.6gDbSNijjW@wuerfel> Date: Wed, 04 Nov 2015 21:41:13 +0000 In-Reply-To: <3941204.6gDbSNijjW@wuerfel> (Arnd Bergmann's message of "Wed, 04 Nov 2015 21:39:46 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1050 Lines: 50 Arnd Bergmann writes: > On Tuesday 27 October 2015 12:57:57 Mans Rullgard wrote: >> --- a/arch/arm/include/debug/8250.S >> +++ b/arch/arm/include/debug/8250.S >> @@ -9,6 +9,18 @@ >> */ >> #include >> >> +#ifdef CONFIG_DEBUG_UART_8250_PALMCHIP >> + >> +#undef UART_TX >> +#undef UART_LSR >> +#undef UART_MSR >> + >> +#define UART_TX 1 >> +#define UART_LSR 7 >> +#define UART_MSR 8 >> + >> +#endif >> > > Maybe use a separate file instead of an #ifdef? > > Something like > > arch/arm/include/debug/8250-palmchip.S: > > #include > > #undef UART_TX > #undef UART_LSR > #undef UART_MSR > > #define UART_TX 1 > #define UART_LSR 7 > #define UART_MSR 8 > > #include "8250.S" Good idea. I'll make a new patch. -- M?ns Rullg?rd mans@mansr.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/