Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031268AbbKDWKE (ORCPT ); Wed, 4 Nov 2015 17:10:04 -0500 Received: from mail.kernel.org ([198.145.29.136]:44491 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030932AbbKDWJ5 (ORCPT ); Wed, 4 Nov 2015 17:09:57 -0500 Date: Wed, 4 Nov 2015 19:09:53 -0300 From: Arnaldo Carvalho de Melo To: Wang Nan Cc: namhyung@kernel.org, lizefan@huawei.com, pi3orama@163.com, linux-kernel@vger.kernel.org, Alexei Starovoitov Subject: Re: [PATCH 1/4] perf tools: Pass available CPU number to clang compiler Message-ID: <20151104220953.GL13236@kernel.org> References: <1446636007-239722-1-git-send-email-wangnan0@huawei.com> <1446636007-239722-2-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1446636007-239722-2-git-send-email-wangnan0@huawei.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3395 Lines: 91 Em Wed, Nov 04, 2015 at 11:20:04AM +0000, Wang Nan escreveu: > This patch introduces a new macro "__NR_CPUS__" to perf's embedded > clang compiler, which represent the available CPU counters in this available "CPU counters"? ENOPARSE :-) > system. BPF program can use this macro to create a map with same > number of system CPUs. For exmaple: example > > struct bpf_map_def SEC("maps") pmu_map = { > .type = BPF_MAP_TYPE_PERF_EVENT_ARRAY, > .key_size = sizeof(int), > .value_size = sizeof(u32), > .max_entries = __NR_CPUS__, > }; I wonder if we shouldn't use the getconf() parameter here, i.e. define _SC_NPROCESSORS_CONF and also provide _SC_NPROCESSORS_ONLN. The kernel uses NR_CPUS, for accessing CONFIG_NR_CPUS, Alexei, what do you think? - Arnaldo > Signed-off-by: Wang Nan > Cc: Arnaldo Carvalho de Melo > Cc: Alexei Starovoitov > Cc: Namhyung Kim > Cc: Zefan Li > Cc: pi3orama@163.com > --- > tools/perf/util/llvm-utils.c | 24 ++++++++++++++++++------ > 1 file changed, 18 insertions(+), 6 deletions(-) > > diff --git a/tools/perf/util/llvm-utils.c b/tools/perf/util/llvm-utils.c > index 4f6a478..80eecef 100644 > --- a/tools/perf/util/llvm-utils.c > +++ b/tools/perf/util/llvm-utils.c > @@ -11,10 +11,11 @@ > #include "cache.h" > > #define CLANG_BPF_CMD_DEFAULT_TEMPLATE \ > - "$CLANG_EXEC -D__KERNEL__ $CLANG_OPTIONS " \ > - "$KERNEL_INC_OPTIONS -Wno-unused-value " \ > - "-Wno-pointer-sign -working-directory " \ > - "$WORKING_DIR -c \"$CLANG_SOURCE\" -target bpf -O2 -o -" > + "$CLANG_EXEC -D__KERNEL__ -D__NR_CPUS__=$NR_CPUS "\ > + "$CLANG_OPTIONS $KERNEL_INC_OPTIONS " \ > + "-Wno-unused-value -Wno-pointer-sign " \ > + "-working-directory $WORKING_DIR " \ > + "-c \"$CLANG_SOURCE\" -target bpf -O2 -o -" > > struct llvm_param llvm_param = { > .clang_path = "clang", > @@ -326,8 +327,8 @@ get_kbuild_opts(char **kbuild_dir, char **kbuild_include_opts) > int llvm__compile_bpf(const char *path, void **p_obj_buf, > size_t *p_obj_buf_sz) > { > - int err; > - char clang_path[PATH_MAX]; > + int err, nr_cpus_avail; > + char clang_path[PATH_MAX], nr_cpus_avail_str[64]; > const char *clang_opt = llvm_param.clang_opt; > const char *template = llvm_param.clang_bpf_cmd_template; > char *kbuild_dir = NULL, *kbuild_include_opts = NULL; > @@ -354,6 +355,17 @@ int llvm__compile_bpf(const char *path, void **p_obj_buf, > */ > get_kbuild_opts(&kbuild_dir, &kbuild_include_opts); > > + nr_cpus_avail = sysconf(_SC_NPROCESSORS_CONF); > + if (nr_cpus_avail <= 0) { > + pr_err( > +"WARNING:\tunable to get available CPUs in this system: %s\n" > +" \tUse 128 instead.\n", strerror(errno)); > + nr_cpus_avail = 128; > + } > + snprintf(nr_cpus_avail_str, sizeof(nr_cpus_avail_str), "%d", > + nr_cpus_avail); > + > + force_set_env("NR_CPUS", nr_cpus_avail_str); > force_set_env("CLANG_EXEC", clang_path); > force_set_env("CLANG_OPTIONS", clang_opt); > force_set_env("KERNEL_INC_OPTIONS", kbuild_include_opts); > -- > 1.8.3.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/