Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031285AbbKEBA4 (ORCPT ); Wed, 4 Nov 2015 20:00:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40084 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030589AbbKEBAz (ORCPT ); Wed, 4 Nov 2015 20:00:55 -0500 From: Laura Abbott To: Russell King , Kees Cook Cc: Laura Abbott , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH] arm: Use kernel mm when updating section permissions Date: Wed, 4 Nov 2015 17:00:39 -0800 Message-Id: <1446685239-28522-1-git-send-email-labbott@fedoraproject.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1516 Lines: 41 Currently, read only permissions are not being applied even when CONFIG_DEBUG_RODATA is set. This is because section_update uses current->mm for adjusting the page tables. current->mm need not be equivalent to the kernel version. Use pgd_offset_k to get the proper page directory for updating. Signed-off-by: Laura Abbott --- I found this while trying to convince myself of something. Dumping the page table via debugfs and writing to kernel text were both showing the lack of mappings. This was observed on QEMU. Maybe it's just a QEMUism but if not it probably should go to stable. --- arch/arm/mm/init.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c index 8a63b4c..4bb936a 100644 --- a/arch/arm/mm/init.c +++ b/arch/arm/mm/init.c @@ -629,11 +629,9 @@ static struct section_perm ro_perms[] = { static inline void section_update(unsigned long addr, pmdval_t mask, pmdval_t prot) { - struct mm_struct *mm; pmd_t *pmd; - mm = current->active_mm; - pmd = pmd_offset(pud_offset(pgd_offset(mm, addr), addr), addr); + pmd = pmd_offset(pud_offset(pgd_offset_k(addr), addr), addr); #ifdef CONFIG_ARM_LPAE pmd[0] = __pmd((pmd_val(pmd[0]) & mask) | prot); -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/