Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756376AbbKEBzw (ORCPT ); Wed, 4 Nov 2015 20:55:52 -0500 Received: from mail-lb0-f177.google.com ([209.85.217.177]:34187 "EHLO mail-lb0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752959AbbKEBzu (ORCPT ); Wed, 4 Nov 2015 20:55:50 -0500 MIME-Version: 1.0 In-Reply-To: <4309044.Hy8Vx01ZVW@wuerfel> References: <4309044.Hy8Vx01ZVW@wuerfel> Date: Thu, 5 Nov 2015 09:55:48 +0800 X-Google-Sender-Auth: JL3Mmy_ppYd5H5KZ9-P4uB1sCJY Message-ID: Subject: Re: [PATCH] PCI: altera: use fwnode API for pci_msi_create_irq_domain From: Ley Foon Tan To: Arnd Bergmann Cc: linux-pci@vger.kernel.org, Bjorn Helgaas , Marc Zyngier , "linux-kernel@vger.kernel.org" , Thomas Gleixner Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1374 Lines: 29 On Wed, Nov 4, 2015 at 8:39 PM, Arnd Bergmann wrote: > There is a new conflict between Thomas Gleixner's IRQ tree that contains > a patch from Marc Zyngier to change the prototype for > pci_msi_create_irq_domain, and Bjorn Helgaas' PCI tree that contains > a new driver for the Altera PCI MSI host, with the old interface, > as gcc now warns in linux-next: > > drivers/pci/host/pcie-altera-msi.c: In function 'altera_allocate_domains': > drivers/pci/host/pcie-altera-msi.c:191:46: warning: passing argument 1 of 'pci_msi_create_irq_domain' from incompatible pointer type [-Wincompatible-pointer-types] > msi->msi_domain = pci_msi_create_irq_domain(msi->pdev->dev.of_node, > include/linux/msi.h:286:20: note: expected 'struct fwnode_handle *' but argument is of type 'struct device_node *' > > This changes the new driver use the modified API. > > Signed-off-by: Arnd Bergmann > Fixes: af1169b48b17 ("PCI: altera: Add Altera PCIe MSI driver") > Fixes: be5436c83ac8 ("irqdomain/msi: Use fwnode instead of of_node") Acked-by: Ley Foon Tan Thanks for the fix. Regards Ley Foon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/