Subject: Re: [PATCH V6 1/1] usb:serial: Add Fintek F81532/534 driver
To: johan@kernel.org
References: <1446522669-18987-1-git-send-email-hpeter+linux_kernel@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, tom_tsai@fintek.com.tw,
        peter_hong@fintek.com.tw, Peter Hung <hpeter+linux_kernel@gmail.com>
From: Peter Hung <hpeter@gmail.com>
Message-ID: <563AC51F.5060605@gmail.com>
Date: Thu, 5 Nov 2015 10:55:27 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <1446522669-18987-1-git-send-email-hpeter+linux_kernel@gmail.com>
Content-Type: text/plain; charset=big5
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1537
Lines: 36

Hi

Peter Hung ?? 2015/11/3 ?W?? 11:51 ?g?D:
> This driver is for Fintek F81532/F81534 USB to Serial Ports IC.
> Changelog:
> v6
>      1. Re-implement the write()/resume() function. Due to this device cant be
>         suitable with generic write(), we'll do the submit write URB when
>         write()/received tx empty/set_termios()/resume()
>      2. Logic/Phy Port mapping rewrite in f81534_port_probe() &
>         f81534_phy_to_logic_port().
>      3. Introduced "Port Hide" function. Some customer use F81532 reference
>         design for HW layout, but really use F81534 IC. We'll check
>         F81534_PORT_CONF_DISABLE_PORT flag with in uart mode field to do
>         port hide with port not used. It can be avoid end-user to use not
>         layouted port.
>      4. The 4x3 output-only open-drain pins for F81532/534 is designed for
>         control outer devices (with our EVB for examples, the 4 sets of pins
>         are designed to control transceiver mode). So we decide to implement
>         with gpiolib interface.

I need to do some improvements with senior advices, so I'll send
v7 patch when I modify & re-test the code complete.

Could you give me some roughly advices of this patch when you having
time.

Thanks for your help
-- 
With Best Regards,
Peter Hung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/