Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031847AbbKEDBQ (ORCPT ); Wed, 4 Nov 2015 22:01:16 -0500 Received: from mail-ob0-f176.google.com ([209.85.214.176]:36640 "EHLO mail-ob0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031599AbbKEDBM (ORCPT ); Wed, 4 Nov 2015 22:01:12 -0500 MIME-Version: 1.0 Reply-To: rajatxjain@gmail.com In-Reply-To: <1446415120-14867-1-git-send-email-linux@roeck-us.net> References: <1446415120-14867-1-git-send-email-linux@roeck-us.net> Date: Wed, 4 Nov 2015 19:01:12 -0800 Message-ID: Subject: Re: [PATCH] PCI: pciehp: Always protect pciehp_disable_slot() with hotplug mutex From: Rajat Jain To: Guenter Roeck Cc: Bjorn Helgaas , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1458 Lines: 37 Geez... I wonder how did I miss it. Thanks for fixing this. Looks good to me. Reviewed-by: Rajat Jain On Sun, Nov 1, 2015 at 1:58 PM, Guenter Roeck wrote: > When called from pciehp_sysfs_disable_slot(), the call to > pciehp_disable_slot() was not protected by the hotplug mutex. > > Cc: Rajat Jain > Signed-off-by: Guenter Roeck > --- > drivers/pci/hotplug/pciehp_ctrl.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pci/hotplug/pciehp_ctrl.c b/drivers/pci/hotplug/pciehp_ctrl.c > index 4c8f4cde6854..880978b6d534 100644 > --- a/drivers/pci/hotplug/pciehp_ctrl.c > +++ b/drivers/pci/hotplug/pciehp_ctrl.c > @@ -511,7 +511,9 @@ int pciehp_sysfs_disable_slot(struct slot *p_slot) > case STATIC_STATE: > p_slot->state = POWEROFF_STATE; > mutex_unlock(&p_slot->lock); > + mutex_lock(&p_slot->hotplug_lock); > retval = pciehp_disable_slot(p_slot); > + mutex_unlock(&p_slot->hotplug_lock); > mutex_lock(&p_slot->lock); > p_slot->state = STATIC_STATE; > break; > -- > 2.1.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/