Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031858AbbKEDCW (ORCPT ); Wed, 4 Nov 2015 22:02:22 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:12207 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031599AbbKEDCT (ORCPT ); Wed, 4 Nov 2015 22:02:19 -0500 Message-ID: <563AC69D.3070606@huawei.com> Date: Thu, 5 Nov 2015 11:01:49 +0800 From: Zhong Kaihua User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Rob Herring CC: Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Catalin Marinas , "Will Deacon" , Yiping Xu , Wei Xu , Bintian Wang , "Haojian Zhuang" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Chen Feng , , , Xinwei Kong Subject: Re: [PATCH 2/3] dt-bindings: gpio: Documentation for Hi6220 gpio driver References: <1446258260-72902-1-git-send-email-zhongkaihua@huawei.com> <1446258260-72902-2-git-send-email-zhongkaihua@huawei.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.142.148.146] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090204.563AC6B6.0095,ss=1,re=0.000,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2011-05-27 18:58:46 X-Mirapoint-Loop-Id: b015228f1273c7d7205380eda590c61c Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2329 Lines: 66 On 2015/11/2 23:09, Rob Herring wrote: > On Fri, Oct 30, 2015 at 9:24 PM, Zhong Kaihua wrote: >> dt-bindings: gpio: Documentation for Hi6220 gpio driver >> >> Signed-off-by: Zhong Kaihua >> --- >> .../devicetree/bindings/gpio/gpio-hi6220.txt | 23 ++++++++++++++++++++++ >> 1 file changed, 23 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-hi6220.txt >> >> diff --git a/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt b/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt >> new file mode 100644 >> index 0000000..76a8932 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt >> @@ -0,0 +1,23 @@ >> +Hisilicon Hi6220 GPIO controller bindings >> + >> +Required properties: >> + - compatible: "arm,pl061", "arm,primecell" >> + - gpio-controller: Marks the device node as a GPIO controller. >> + - #gpio-cells: Should be 2. See gpio.txt in this directory for a > > Some strange spacing in here. Otherwise, > > Acked-by: Rob Herring Style problems have been fixed in V2 patch. Rearrange the document patch to the first of patch set. > >> + description of the cells format. >> + - interrupt-controller: Mark the device node as an interrupt controller >> + >> +Example: >> + >> + gpio0: gpio@f8011000 { >> + compatible = "arm,pl061", "arm,primecell"; >> + reg = <0x0 0xf8011000 0x0 0x1000>; >> + interrupts = <0 52 0x4>; >> + gpio-controller; >> + #gpio-cells = <2>; >> + interrupt-controller; >> + #interrupt-cells = <2>; >> + clocks = <&ao_ctrl 2>; >> + clock-names = "apb_pclk"; >> + status = "ok"; >> + }; >> -- >> 1.9.1 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe devicetree" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > . > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/