Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031868AbbKEDDf (ORCPT ); Wed, 4 Nov 2015 22:03:35 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:59712 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031664AbbKEDDe (ORCPT ); Wed, 4 Nov 2015 22:03:34 -0500 Date: Wed, 04 Nov 2015 22:03:32 -0500 (EST) Message-Id: <20151104.220332.1882923396348027768.davem@davemloft.net> To: stefanha@redhat.com Cc: netdev@vger.kernel.org, thellstrom@vmware.com, asarwade@vmware.com, jhansen@vmware.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] VSOCK: call sk->sk_data_ready() on accept() From: David Miller In-Reply-To: <1446641922-32243-1-git-send-email-stefanha@redhat.com> References: <1446641922-32243-1-git-send-email-stefanha@redhat.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 04 Nov 2015 19:03:34 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 967 Lines: 22 From: Stefan Hajnoczi Date: Wed, 4 Nov 2015 12:58:42 +0000 > When a listen socket enqueues a connection for userspace to accept(), > the sk->sk_data_ready() callback should be invoked. In-kernel socket > users rely on this callback to detect when incoming connections are > available. > > Currently the sk->sk_state_change() callback is invoked by > vmci_transport.c. This happens to work for userspace applications since > sk->sk_state_change = sock_def_wakeup() and sk->sk_data_ready = > sock_def_readable() both wake up the accept() waiter. In-kernel socket > users, on the other hand, fail to detect incoming connections. > > Signed-off-by: Stefan Hajnoczi Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/